Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: samples/swarm/Views.dart

Issue 12317107: ceil/floor/truncate/round return integers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Some fixes from CL 11748016. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/swarm/Views.dart
diff --git a/samples/swarm/Views.dart b/samples/swarm/Views.dart
index ea9662b1db91959cba17a035a1b5b23c92fa8246..12722b717d92eba2f0b5db1581bab7ac3e2f5717 100644
--- a/samples/swarm/Views.dart
+++ b/samples/swarm/Views.dart
@@ -669,20 +669,20 @@ class FixedSizeListViewLayout<D> implements ListViewLayout<D> {
}
int getPageLength(int viewLength) {
- final itemsPerPage = (viewLength / _itemLength).floor();
- return (Math.max(1, itemsPerPage) * _itemLength).toInt();
+ final itemsPerPage = viewLength ~/ _itemLength;
+ return Math.max(1, itemsPerPage) * _itemLength;
}
int getPage(int index, int viewLength) {
- return (getOffset(index) / getPageLength(viewLength)).floor().toInt();
+ return getOffset(index) ~/ getPageLength(viewLength);
}
int getPageStartIndex(int page, int viewLength) {
- return (getPageLength(viewLength) / _itemLength).toInt() * page;
+ return getPageLength(viewLength) ~/ _itemLength * page;
}
int getSnapIndex(num offset, int viewLength) {
- int index = (-offset / _itemLength).round().toInt();
+ int index = (-offset / _itemLength).round();
if (_paginate) {
index = getPageStartIndex(getPage(index, viewLength), viewLength);
}

Powered by Google App Engine
This is Rietveld 408576698