sdk/lib/core/date_time.dart - Issue 12317107: ceil/floor/truncate/round return integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/date_time.dart

Issue 12317107: ceil/floor/truncate/round return integers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reupload due to error3 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/core/date_time.dart

diff --git a/sdk/lib/core/date_time.dart b/sdk/lib/core/date_time.dart

index 1acd412cc7c21792b056aa6ba3f63dcd7d558668..5b26fc8151f658791b3b88bb936a3ea3d4855230 100644

--- a/sdk/lib/core/date_time.dart

+++ b/sdk/lib/core/date_time.dart

@@ -135,7 +135,7 @@ class DateTime {

int minute = parseIntOrZero(match[5]);

int second = parseIntOrZero(match[6]);

bool addOneMillisecond = false;

- int millisecond = (parseDoubleOrZero(match[7]) * 1000).round().toInt();

+ int millisecond = (parseDoubleOrZero(match[7]) * 1000).round();

if (millisecond == 1000) {

addOneMillisecond = true;

millisecond = 999;