sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart - Issue 12317107: ceil/floor/truncate/round return integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

Issue 12317107: ceil/floor/truncate/round return integers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reupload due to error3 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

index fa5384f22ffcd4aeb72026b25dda1cadf14441c7..1b4a0ffd81d0c3bd9cc707bcec148241bb194684 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

@@ -199,7 +199,7 @@ class JavaScriptConstantSystem extends ConstantSystem {

double doubleValue = doubleResult.value;

if (!doubleValue.isInfinite && !doubleValue.isNaN &&

!constant.isMinusZero()) {

- int intValue = doubleValue.toInt();

+ int intValue = doubleValue.truncate();

if (intValue == doubleValue && integerFitsIntoDouble(intValue)) {

return new IntConstant(intValue);

}

« no previous file with comments | « samples/third_party/dromaeo/common/Math2.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_number.dart » ('j') | no next file with comments »