build/android/pylib/gtest/test_runner.py - Issue 12317059: [Andoid] Threaded TestRunner creation and SetUp and TearDown calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_runner.py

Issue 12317059: [Andoid] Threaded TestRunner creation and SetUp and TearDown calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: improved naming, comments, and simplified logic in threadsafe test collection Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_runner.py

diff --git a/build/android/pylib/gtest/test_runner.py b/build/android/pylib/gtest/test_runner.py

index 0ecc9c5a787cb39ded4e5a47234bfe524329793b..917ed40129cfa1316273e9358cd9ee4db757eb87 100644

--- a/build/android/pylib/gtest/test_runner.py

+++ b/build/android/pylib/gtest/test_runner.py

@@ -254,6 +254,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

return test_results, None

try:

+ self.test_package.ClearApplicationState()

self.test_package.CreateTestRunnerScript(test, self._test_arguments)

test_results = self.test_package.RunTestsAndListResults()

except errors.DeviceUnresponsiveError as e:

@@ -275,7 +276,6 @@ class TestRunner(base_test_runner.BaseTestRunner):

def SetUp(self):

"""Sets up necessary test enviroment for the test suite."""

super(TestRunner, self).SetUp()

- self.adb.ClearApplicationState(constants.CHROME_PACKAGE)

self.StripAndCopyFiles()

if _TestSuiteRequiresMockTestServer(self.test_package.test_suite_basename):

self.LaunchChromeTestServerSpawner()