Chromium Code Reviews| Index: android_webview/android_webview_tests.gypi |
| diff --git a/android_webview/android_webview_tests.gypi b/android_webview/android_webview_tests.gypi |
| index 95b51dc5c2a9a7a2a7975a23fcc884815c568801..45a65c4c5de318b72d94125796f10e4e6c470cba 100644 |
| --- a/android_webview/android_webview_tests.gypi |
| +++ b/android_webview/android_webview_tests.gypi |
| @@ -4,20 +4,33 @@ |
| { |
| 'targets': [ |
| { |
| - 'target_name': 'android_webview_test_apk', |
| + 'target_name': 'android_webview_test_java', |
| 'type': 'none', |
| 'dependencies': [ |
| '../base/base.gyp:base_java_test_support', |
| '../content/content.gyp:content_java_test_support', |
| '../net/net.gyp:net_java_test_support', |
| - 'android_webview_java', |
| + 'android_webview_java', |
| 'libwebviewchromium', |
| ], |
| 'variables': { |
| - 'apk_name': 'AndroidWebViewTest', |
| 'java_in_dir': '../android_webview/javatests', |
| - 'resource_dir': 'res', |
| - 'is_test_apk': 1, |
| + 'has_java_resources': 1, |
| + 'R_package': 'org.chromium.android_webview.test', |
| + 'R_package_relpath': 'org/chromium/android_webview/test', |
| + }, |
| + 'includes': [ '../build/java.gypi' ], |
| + }, |
| + { |
| + 'target_name': 'android_webview_test_apk', |
| + 'type': 'none', |
| + 'dependencies': [ |
| + 'android_webview_test_java', |
| + ], |
| + 'variables': { |
| + 'apk_name': 'AndroidWebViewTest', |
| + 'java_in_dir': '../android_webview/test_apk', |
| + 'is_test_apk': 0, # We want resources from android_webview_test_java. |
|
benm (inactive)
2013/03/19 12:55:01
We could just remove this, I think it defaults to
mkosiba (inactive)
2013/03/19 17:11:26
I wanted some place to stick the comment in. It se
|
| 'additional_input_paths': [ |
| '<(PRODUCT_DIR)/android_webview_test_apk/assets/asset_file.html', |
| '<(PRODUCT_DIR)/android_webview_test_apk/assets/asset_icon.png', |
| @@ -37,6 +50,25 @@ |
| 'includes': [ '../build/java_apk.gypi' ], |
| }, |
| { |
| + 'target_name': 'android_webview_shell_apk', |
| + 'type': 'none', |
| + 'dependencies': [ |
| + 'android_webview_test_java', |
| + 'android_webview_pak', |
| + ], |
| + 'variables': { |
| + 'apk_name': 'AndroidWebViewShell', |
| + 'java_in_dir': '../android_webview/shell_apk', |
| + 'native_libs_paths': ['<(SHARED_LIB_DIR)/libwebviewchromium.so'], |
|
benm (inactive)
2013/03/19 12:55:01
Why doesn't android_webview_test_apk need this var
mkosiba (inactive)
2013/03/19 17:11:26
because the test apk only contains test code and a
|
| + 'resource_dir': 'res', |
| + 'asset_location': '<(ant_build_out)/android_webview_apk/assets', |
|
benm (inactive)
2013/03/19 12:55:01
could we refactor the android_webview_test_apk to
mkosiba (inactive)
2013/03/19 17:11:26
not sure, nobody uses it like that in the tree. Wo
|
| + 'additional_input_paths': [ |
| + '<(PRODUCT_DIR)/android_webview_apk/assets/webviewchromium.pak', |
| + ], |
| + }, |
| + 'includes': [ '../build/java_apk.gypi' ], |
| + }, |
| + { |
| 'target_name': 'android_webview_unittests', |
| 'type': '<(gtest_target_type)', |
| 'dependencies': [ |