Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1231693003: Card "swipe-away" dismiss version 2 (Closed)

Created:
5 years, 5 months ago by hansmuller1
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Card "swipe-away" dismiss version 2 Some minor cleanup. Also created a small mess to work around https://github.com/domokit/mojo/issues/312 - Track event.dx sum; don't listen to the card container - Support dismissing to the left (too) - Slow the dismiss "fling" animation down a little. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a847c18a68b2426824a5572de02187c63b771b25

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M sky/sdk/example/widgets/card_collection.dart View 6 chunks +35 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hansmuller
PTAL
5 years, 5 months ago (2015-07-09 00:00:25 UTC) #4
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 00:44:38 UTC) #6
hansmuller1
5 years, 5 months ago (2015-07-09 15:14:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a847c18a68b2426824a5572de02187c63b771b25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698