Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1231673007: Don't zoom in TextFinder if autosizing is disabled (Closed)

Created:
5 years, 5 months ago by sebastianl
Modified:
5 years, 5 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't zoom in TextFinder if autosizing is disabled On android devices the zoom-level is always being reset if the viewed page doesn't use/need text autosizing. Therefore, only zoom to content if autosizing is set. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199027

Patch Set 1 #

Total comments: 2

Patch Set 2 : added unittest, moved #include #

Total comments: 1

Patch Set 3 : removed frame() helper from test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M Source/core/layout/TextAutosizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/TextAutosizer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/TextFinder.cpp View 1 2 chunks +7 lines, -3 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 2 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
sebastianl
Only change zoom-level when calling TextFinder.Find if autosizing is set for the page. This to ...
5 years, 5 months ago (2015-07-14 13:26:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231673007/1
5 years, 5 months ago (2015-07-14 13:29:30 UTC) #4
philipj_slow
Hi all, Sebastian showed me the email exchange you all had where it seemed like ...
5 years, 5 months ago (2015-07-14 13:29:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 14:36:46 UTC) #7
skobes
If possible, add a test case to TextFinderTest. https://codereview.chromium.org/1231673007/diff/1/Source/web/TextFinder.cpp File Source/web/TextFinder.cpp (right): https://codereview.chromium.org/1231673007/diff/1/Source/web/TextFinder.cpp#newcode158 Source/web/TextFinder.cpp:158: if ...
5 years, 5 months ago (2015-07-14 17:11:28 UTC) #8
sebastianl
On 2015/07/14 17:11:28, skobes wrote: > If possible, add a test case to TextFinderTest. Found ...
5 years, 5 months ago (2015-07-15 09:15:40 UTC) #9
sebastianl
5 years, 5 months ago (2015-07-15 09:16:37 UTC) #10
skobes
lgtm
5 years, 5 months ago (2015-07-15 17:43:28 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231673007/20001
5 years, 5 months ago (2015-07-16 07:39:01 UTC) #15
philipj_slow
https://codereview.chromium.org/1231673007/diff/20001/Source/web/tests/TextFinderTest.cpp File Source/web/tests/TextFinderTest.cpp (right): https://codereview.chromium.org/1231673007/diff/20001/Source/web/tests/TextFinderTest.cpp#newcode157 Source/web/tests/TextFinderTest.cpp:157: PinchViewport& pinchViewport = frame().page()->frameHost().pinchViewport(); Would document().page() do the same ...
5 years, 5 months ago (2015-07-16 07:44:18 UTC) #16
sebastianl
On 2015/07/16 07:44:18, philipj wrote: > https://codereview.chromium.org/1231673007/diff/20001/Source/web/tests/TextFinderTest.cpp > File Source/web/tests/TextFinderTest.cpp (right): > > https://codereview.chromium.org/1231673007/diff/20001/Source/web/tests/TextFinderTest.cpp#newcode157 > ...
5 years, 5 months ago (2015-07-16 07:53:58 UTC) #17
philipj_slow
lgtm
5 years, 5 months ago (2015-07-16 07:58:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231673007/40001
5 years, 5 months ago (2015-07-16 07:58:23 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/71355)
5 years, 5 months ago (2015-07-16 09:36:29 UTC) #23
philipj_slow
On 2015/07/16 09:36:29, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-07-16 09:41:45 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231673007/40001
5 years, 5 months ago (2015-07-16 09:42:07 UTC) #26
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 11:16:15 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199027

Powered by Google App Engine
This is Rietveld 408576698