Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1231643009: create another copy of libraries.dart for 1.12-dev SDK (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

create another copy of libraries.dart for 1.12-dev SDK also adds .packages to .gitignore Note: this isn't enough to fix things yet, it seems 0.25.1 analyzer has other breaking changes R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/144eab1ca9ae3e5432008993b00e6ab38ef4955a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M .gitignore View 1 chunk +2 lines, -1 line 0 comments Download
M tool/patch_sdk.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 5 months ago (2015-07-09 16:16:57 UTC) #2
vsm
lgtm
5 years, 5 months ago (2015-07-09 16:17:42 UTC) #3
Jennifer Messerly
5 years, 5 months ago (2015-07-09 16:36:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
144eab1ca9ae3e5432008993b00e6ab38ef4955a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698