Sort GL extension strings and search to find.

Sort GL extension strings and search to find.
Committed: https://code.google.com/p/skia/source/detail?r=7889

[bsalomon, 2013-02-26 22:43:48]

Not critically important but two kinda funky things we're discovered along the
way:

1) SkTSort and SkTSearch use different comparisons (bool functor vs int
function)

2) We can specialize SkTSwap for classes that have smart swaps.

[robertphillips, 2013-02-26 23:02:37]

lgtm

[reed1, 2013-02-26 23:05:44]

https://codereview.chromium.org/12316141/diff/1/include/core/SkString.h
File include/core/SkString.h (right):

https://codereview.chromium.org/12316141/diff/1/include/core/SkString.h#newco...
include/core/SkString.h:247: template <> inline void SkTSwap(SkString& a,
SkString& b) {
// Specialize SkTSwap (SkTypes.h) for SkString, so we can efficiently be used by
SkTSort

Maybe we also add comments on SkTSwap itself (e.g. // classes with efficient
swaps should specialize me) and SkTSort (e.g. // calls SkTSwap, so be sure your
datatype is specialzed for this).

https://codereview.chromium.org/12316141/diff/1/src/core/SkTSort.h
File src/core/SkTSort.h (right):

https://codereview.chromium.org/12316141/diff/1/src/core/SkTSort.h#newcode208
src/core/SkTSort.h:208: /** Adapts an SkTSearch comparison function to a SkTSort
functor */
Why is the functor called COMPARE instead of LT or COMPARE_LT?

[bsalomon, 2013-02-27 16:56:35]

https://codereview.chromium.org/12316141/diff/1/include/core/SkString.h
File include/core/SkString.h (right):

https://codereview.chromium.org/12316141/diff/1/include/core/SkString.h#newco...
include/core/SkString.h:247: template <> inline void SkTSwap(SkString& a,
SkString& b) {
On 2013/02/26 23:05:44, reed1 wrote:
> // Specialize SkTSwap (SkTypes.h) for SkString, so we can efficiently be used
by
> SkTSort
> 
> Maybe we also add comments on SkTSwap itself (e.g. // classes with efficient
> swaps should specialize me) and SkTSort (e.g. // calls SkTSwap, so be sure
your
> datatype is specialzed for this).

Done.

https://codereview.chromium.org/12316141/diff/1/src/core/SkTSort.h
File src/core/SkTSort.h (right):

https://codereview.chromium.org/12316141/diff/1/src/core/SkTSort.h#newcode208
src/core/SkTSort.h:208: /** Adapts an SkTSearch comparison function to a SkTSort
functor */
On 2013/02/26 23:05:44, reed1 wrote:
> Why is the functor called COMPARE instead of LT or COMPARE_LT?

Done, and made the comment a bit more explicit about what this is doing.

[reed1, 2013-02-27 16:59:17]

lgtm

[bsalomon, 2013-02-27 19:07:36]

Committed patchset #3 manually as r7889 (presubmit successful).