Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 12316132: mac content shell drt: Do not disable antialiasing via NSDefaults (Closed)

Created:
7 years, 10 months ago by Nico
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

mac content shell drt: Do not disable antialiasing via NSDefaults Skia does this itself in layout test mode, but it needs to be able to draw subpixel text to check for something for its logic to work. With this change (and https://bugs.webkit.org/show_bug.cgi?id=110890 and https://codereview.chromium.org/12315103/), animations/3d/change-transform-in-end-event.html passes locally (including pixel test) with content shell drt (which matches regular drt's behavior) \o/ BUG=111316 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/shell/webkit_test_platform_support_mac.mm View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 10 months ago (2013-02-26 18:19:35 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 10 months ago (2013-02-26 18:31:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12316132/1
7 years, 10 months ago (2013-02-26 18:55:48 UTC) #3
Nico
7 years, 10 months ago (2013-02-26 19:13:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r184686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698