Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: media/audio/audio_manager_base.cc

Issue 12316131: Moved AudioUtil static functions to AudioManager interfaces (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 39b70e51513433617b3744b926a3d265b3ee74bc..b2c95cd203ae97ec9008fe0f4086339b4b62c28c 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -385,10 +385,11 @@ AudioParameters AudioManagerBase::GetPreferredLowLatencyOutputStreamParameters(
#else
// TODO(dalecurtis): This should include bits per channel and channel layout
// eventually.
+ AudioParameters default_params = GetDefaultOutputStreamParameters();
return AudioParameters(
AudioParameters::AUDIO_PCM_LOW_LATENCY,
input_params.channel_layout(), input_params.input_channels(),
- GetAudioHardwareSampleRate(), 16, GetAudioHardwareBufferSize());
+ default_params.sample_rate(), 16, default_params.frames_per_buffer());
#endif // defined(OS_IOS)
}
@@ -404,6 +405,15 @@ void AudioManagerBase::RemoveOutputDeviceChangeListener(
output_listeners_.RemoveObserver(listener);
}
+AudioParameters AudioManagerBase::GetDefaultOutputStreamParameters() {
+ return AudioParameters();
Chris Rogers 2013/02/27 20:06:14 seems a bit dangerous -- should probably add NOTRE
tommi (sloooow) - chröme 2013/03/01 11:29:29 Can we make these methods pure virtual?
no longer working on chromium 2013/03/01 16:44:33 Done.
no longer working on chromium 2013/03/01 16:44:33 I make it pure virtual to for the developer to imp
+}
+
+AudioParameters AudioManagerBase::GetDefaultInputStreamParameters(
+ const std::string& device_id) {
+ return AudioParameters();
Chris Rogers 2013/02/27 20:06:14 seems a bit dangerous -- should probably add NOTRE
no longer working on chromium 2013/03/01 16:44:33 Done.
+}
+
void AudioManagerBase::NotifyAllOutputDeviceChangeListeners() {
DCHECK(message_loop_->BelongsToCurrentThread());
DVLOG(1) << "Firing OnDeviceChange() notifications.";

Powered by Google App Engine
This is Rietveld 408576698