media/audio/mac/audio_device_listener_mac.cc - Issue 12316131: Moved AudioUtil static functions to AudioManager interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/mac/audio_device_listener_mac.cc

Issue 12316131: Moved AudioUtil static functions to AudioManager interfaces (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: made the GetPreferredOutputStreamParameters protected Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/mac/audio_device_listener_mac.cc

diff --git a/media/audio/mac/audio_device_listener_mac.cc b/media/audio/mac/audio_device_listener_mac.cc

index 65a48543d79d382b5cf01cddea8eb4fe6b0d1765..24da08ac61b97e337a164b3fc84d9c9f2ef89b78 100644

--- a/media/audio/mac/audio_device_listener_mac.cc

+++ b/media/audio/mac/audio_device_listener_mac.cc

@@ -125,8 +125,8 @@ AudioDeviceListenerMac::AudioDeviceListenerMac(const base::Closure& listener_cb)

// by pausing and resuming the dispatch queue before and after each pumped

// task. This is not ideal and long term we should replace the audio thread

// on OSX with a dispatch queue. See http://crbug.com/158170 for discussion.

- // TODO(dalecurtis): Does not fix the cases where GetAudioHardwareSampleRate()

- // and GetAudioInputHardwareSampleRate() are called by the browser process.

+ // TODO(dalecurtis): Does not fix the cases where

+ // GetDefaultOutputStreamParameters() are called by the browser process.

// These are one time events due to renderer side cache and thus unlikely to

// occur at the same time as a device callback. Should be fixed along with

// http://crbug.com/137326 using a forced PostTask.