Chromium Code Reviews| Index: media/audio/audio_manager_base.h |
| diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h |
| index 22140cbe2a1d4fb91b17aa0bb96f5e58f26cee9f..896fa370026978a1b4b221e3d97b33e95d87f279 100644 |
| --- a/media/audio/audio_manager_base.h |
| +++ b/media/audio/audio_manager_base.h |
| @@ -84,13 +84,12 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager { |
| const AudioParameters& params, const std::string& device_id) = 0; |
| // Returns the preferred hardware audio output parameters for opening output |
| - // streams in the |AUDIO_PCM_LOW_LATENCY| format. |
| - // TODO(dalecurtis): Retrieve the |channel_layout| value from hardware instead |
| - // of accepting the value. |
| - // TODO(dalecurtis): Each AudioManager should implement their own version, see |
| - // http://crbug.com/137326 |
| - virtual AudioParameters GetPreferredLowLatencyOutputStreamParameters( |
| - const AudioParameters& input_params); |
| + // streams. If the users inject a valid |input_params|, each AudioManager |
| + // will decide if they should return the values from |input_params| or the |
| + // default hardware values. If the |input_params| is invalid, it will return |
| + // the default hardware audio parameters. |
| + virtual AudioParameters GetPreferredOutputStreamParameters( |
|
DaleCurtis
2013/03/05 01:40:53
Move to protected? Ditto for implementations.
no longer working on chromium
2013/03/05 10:09:35
Done.
|
| + const AudioParameters& input_params) = 0; |
| // Listeners will be notified on the AudioManager::GetMessageLoop() loop. |
| virtual void AddOutputDeviceChangeListener( |
| @@ -98,6 +97,10 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager { |
| virtual void RemoveOutputDeviceChangeListener( |
| AudioDeviceListener* listener) OVERRIDE; |
| + virtual AudioParameters GetDefaultOutputStreamParameters() OVERRIDE; |
| + virtual AudioParameters GetInputStreamParameters( |
| + const std::string& device_id) OVERRIDE; |
| + |
| protected: |
| AudioManagerBase(); |