Make NumberFormat use the ICU currency data, fix bug in NumberFormat

src/i18n.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // limitations under the License.
 
 #include "src/i18n.h"
 
 #include "unicode/brkiter.h"
 #include "unicode/calendar.h"
 #include "unicode/coll.h"
@@ skipping 240 matching lines @@
       if (display == UNICODE_STRING_SIMPLE("code")) {
         format_style = UNUM_CURRENCY_ISO;
       } else if (display == UNICODE_STRING_SIMPLE("name")) {
         format_style = UNUM_CURRENCY_PLURAL;
       } else {
         format_style = UNUM_CURRENCY;
       }
 #endif
 
       number_format = static_cast<icu::DecimalFormat*>(
-          icu::NumberFormat::createInstance(icu_locale, format_style,  status));
+          icu::NumberFormat::createInstance(icu_locale, format_style, status));
+
+      if (U_FAILURE(status)) {
+        delete number_format;
+        return NULL;
+      }
+

[mnita, 2015/07/17 15:48:53]

Two main worries:

1. Looks like the code uses the ICU defaults no matter if the javascript code
specified min/max fraction digits or not.

2. It is not OK to use the currency defaults for all number formatting types.

  2.1 There are currencies that use zero fraction digits by default, because the
currency does not have sub-units.
Example for ja_JP:
   currency: ￥54,306
   number: 54,306.405
   percent: 64%
   scientific: 5.4306404797E4

  2.2 The currency precision is not only locale-dependent, but also currency
dependent. For instance all locales will format the Japanese Yen with not
fractional part. So ucurr_getDefaultFractionDigits, which does not look at the
currency code, will not do the right thing.

Why not just use what ICU returns, "as is", unless caller of the Javascript API
specified the min / max fraction digits?

+      UErrorCode status_digits = U_ZERO_ERROR;
+      uint32_t fraction_digits = ucurr_getDefaultFractionDigits(
+        currency.getTerminatedBuffer(), &status_digits);
+      if (U_SUCCESS(status_digits)) {
+        number_format->setMinimumFractionDigits(fraction_digits);
+        number_format->setMaximumFractionDigits(fraction_digits);
+      } else {
+        // Set min & max to default values (previously in i18n.js)
+        number_format->setMinimumFractionDigits(0);
+        number_format->setMaximumFractionDigits(3);
+      }
     } else if (style == UNICODE_STRING_SIMPLE("percent")) {
       number_format = static_cast<icu::DecimalFormat*>(
           icu::NumberFormat::createPercentInstance(icu_locale, status));
       if (U_FAILURE(status)) {
         delete number_format;
         return NULL;
       }
       // Make sure 1.1% doesn't go into 2%.
       number_format->setMinimumFractionDigits(1);
     } else {
@@ skipping 670 matching lines @@
 
 void BreakIterator::DeleteBreakIterator(
     const v8::WeakCallbackData<v8::Value, void>& data) {
   DeleteNativeObjectAt<icu::BreakIterator>(data, 0);
   DeleteNativeObjectAt<icu::UnicodeString>(data, 1);
   DestroyGlobalHandle(data);
 }
 
 }  // namespace internal
 }  // namespace v8