Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: tools/valgrind.supp

Issue 1231613004: Temporarily suppress valgrind errors in tip of tree libjpeg-turbo (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind.supp
diff --git a/tools/valgrind.supp b/tools/valgrind.supp
index ffb71089f903408d81f5b47143267509b46c78de..2bbf873038120f8ee142448e23559f688bde5f38 100644
--- a/tools/valgrind.supp
+++ b/tools/valgrind.supp
@@ -236,3 +236,65 @@
Memcheck:Addr2
fun:_ZN22GrAAConvexPathRenderer10onDrawPathERK6SkPathRK11SkStrokeRecP12GrDrawTargetb
}
+
+# Valgrind issues caused by tip of tree libjpeg-turbo
+# https://code.google.com/p/skia/issues/detail?id=4030
+# TODO (msarett): Determine if any of these errors relate to jpeg_skip_scanlines() and fix those.
+# Issue 4 looks like it may.
+# Some of these errors may be fixed when we switch to Chromium's version of turbo.
+# If they are not fixed in Chromium's version, they need to be fixed after we switch.
+{
+ turbo_issue_1
+ Memcheck:Value8
+ fun:_itoa_word
+ fun:vfprintf
+ fun:__vsnprintf_chk
+ fun:_ZN8SkString7appendfEPKcz
+ fun:_ZN4Task3RunEPS_
+ fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
+ fun:_ZL12thread_startPv
+ fun:start_thread
+ fun:clone
+}
+{
+ turbo_issue_2
+ Memcheck:Cond
+ fun:vfprintf
+ fun:__vsnprintf_chk
+ fun:_ZN8SkString7appendfEPKcz
+ fun:_ZN4Task3RunEPS_
+ fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
+ fun:_ZL12thread_startPv
+ fun:start_thread
+ fun:clone
+}
+{
+ turbo_issue_3
+ Memcheck:Cond
+ fun:_itoa_word
+ fun:vfprintf
+ fun:__vsnprintf_chk
+ fun:_ZN8SkString7appendfEPKcz
+ fun:_ZN4Task3RunEPS_
+ fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
+ fun:_ZL12thread_startPv
+ fun:start_thread
+ fun:clone
+}
+{
+ turbo_issue_4
+ Memcheck:Value8
+ fun:ycc_rgb565D_convert
+ fun:sep_upsample
+ fun:process_data_context_main
+ fun:turbo_jpeg_read_scanlines
+ fun:turbo_jpeg_skip_scanlines
+ fun:_ZN21SkJpegScanlineDecoder15onSkipScanlinesEi
+ fun:_ZNK2DM8CodecSrc4drawEP8SkCanvas
+ fun:_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString
+ fun:_ZN4Task3RunEPS_
+ fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
+ fun:_ZL12thread_startPv
+ fun:start_thread
+ fun:clone
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698