Add UMA statistics for tracking session storage database opening failures.

Add UMA statistics for tracking session storage database opening failures.

R=michaeln
BUG=NONE


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184925

[marja, 2013-02-26 15:37:30]

ptal

(Background: e-mail discussion 2 weeks or so ago; we don't have statistics about
how often the session storage database fails to open.)

[michaeln, 2013-02-27 00:31:57]

lgtm with one nit

https://codereview.chromium.org/12316124/diff/2001/webkit/dom_storage/session...
File webkit/dom_storage/session_storage_database.cc (right):

https://codereview.chromium.org/12316124/diff/2001/webkit/dom_storage/session...
webkit/dom_storage/session_storage_database.cc:21: 
Can you define a constant for histogram name value here too.

[marja, 2013-02-27 08:48:25]

Thanks for review!

https://codereview.chromium.org/12316124/diff/2001/webkit/dom_storage/session...
File webkit/dom_storage/session_storage_database.cc (right):

https://codereview.chromium.org/12316124/diff/2001/webkit/dom_storage/session...
webkit/dom_storage/session_storage_database.cc:21: 
On 2013/02/27 00:31:57, michaeln wrote:
> Can you define a constant for histogram name value here too.

Done. I just #define'd it, because we cannot have a std::string here, that would
create a non-trivial static initializer afaics... const char* would work, but it
seems to be discouraged. Let me know if you'd like something else than a
#define.

[commit-bot: I haz the power, 2013-02-27 08:48:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/12316124/6001

[commit-bot: I haz the power, 2013-02-27 10:49:56]

Change committed as 184925

[michaeln, 2013-02-27 20:31:48]

https://chromiumcodereview.appspot.com/12316124/diff/2001/webkit/dom_storage/...
File webkit/dom_storage/session_storage_database.cc (right):

https://chromiumcodereview.appspot.com/12316124/diff/2001/webkit/dom_storage/...
webkit/dom_storage/session_storage_database.cc:21: 
I would expect compilers to optimize the multiple uses into one byte sequence in
the binary but its a leap of faith. Elsewhere we do like this...
const char kHttpScheme[] = "http";

> On 2013/02/27 00:31:57, michaeln wrote:
> > Can you define a constant for histogram name value here too.
> 
> Done. I just #define'd it, because we cannot have a std::string here, that
would
> create a non-trivial static initializer afaics... const char* would work, but
it
> seems to be discouraged. Let me know if you'd like something else than a
> #define.