Serialization library. Useful for sending more complex data in RPCs.

Serialization library.  Useful for sending more complex data in RPCs.

This CL contains a definition for the SerializationBuffer class, which
allows simple numeric types, std::string, and std::vector to be
serialized into a byte buffer for transmission via some IPC mechanism
or for storage.  The SerializationBuffer can be constructed from
received data, and the data elements deserialized.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3318

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10909

[bsy, 2013-02-25 23:00:11]

please take a look.  also, what is your opinion on just handling generic stl
containers versus just vectors?  for sending the command line args to the
zygote, we only need std::vector<std::string>.

[sehr, 2013-02-26 00:57:58]

Nits.  Still looking a bit more.

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
File src/shared/serialization/serialization.cc (right):

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.cc:33: }
memcpy?

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
File src/shared/serialization/serialization.h (right):

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.h:64: // This passes initializes the
Serialization buffer from
s/passes //

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.h:79: if (bytes_unread() < 1) {
kTagBytes rather than 1.

[bsy, 2013-02-26 01:05:01]

thanks.  will upload after getting & responding to rest of feedback.

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
File src/shared/serialization/serialization.cc (right):

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.cc:33: }
On 2013/02/26 00:57:58, sehr1 wrote:
> memcpy?

Done.

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
File src/shared/serialization/serialization.h (right):

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.h:64: // This passes initializes the
Serialization buffer from
On 2013/02/26 00:57:58, sehr1 wrote:
> s/passes //

Done.

https://codereview.chromium.org/12316093/diff/21019/src/shared/serialization/...
src/shared/serialization/serialization.h:79: if (bytes_unread() < 1) {
On 2013/02/26 00:57:58, sehr1 wrote:
> kTagBytes rather than 1.

Done.

[sehr, 2013-02-26 16:10:30]

LGTM, and thanks for adding this long-overdue part.

[bsy, 2013-02-26 19:47:53]

Committed manually as r10909 (presubmit successful).