Issue 12316090: Remove forwarding include for base/files/file_path except for MTPD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12316090: Remove forwarding include for base/files/file_path except for MTPD. (Closed)

Created:
7 years, 10 months ago by brettw

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, feature-media-reviews_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, darin-cc_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove forwarding include for base/files/file_path except for MTPD. Fix up remaining/new uses of base/file_path.h MTPD must be updated in a separate pass due to a circular dependency. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184358

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	base/file_path.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/android/chrome_web_contents_delegate_android.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/device_local_account_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/printer_job_queue_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/chrome_test_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/pulse/audio_manager_pulse.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/host_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/generate_library_loader/generate_library_loader.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r184358.

Expand Messages | Collapse Messages