Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: cc/picture_layer_impl.cc

Issue 12316084: cc: Consolidate the analysis_canvas operations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win warning fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/picture.cc ('k') | cc/picture_layer_tiling_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/picture_layer_impl.cc
diff --git a/cc/picture_layer_impl.cc b/cc/picture_layer_impl.cc
index e4bb4441ad584481392cd28348ba3271cd361691..0765c9d26357017d291af329da8ecf3041e7b815 100644
--- a/cc/picture_layer_impl.cc
+++ b/cc/picture_layer_impl.cc
@@ -114,8 +114,11 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
++iter) {
SkColor color;
float width;
- if (*iter && iter->GetResourceId()) {
- if (iter->priority(ACTIVE_TREE).resolution == HIGH_RESOLUTION) {
+ if (*iter && iter->IsReadyToDraw()) {
+ if (iter->is_solid_color() || iter->is_transparent()) {
+ color = DebugColors::SolidColorTileBorderColor();
+ width = DebugColors::SolidColorTileBorderWidth(layerTreeImpl());
+ } else if (iter->priority(ACTIVE_TREE).resolution == HIGH_RESOLUTION) {
color = DebugColors::HighResTileBorderColor();
width = DebugColors::HighResTileBorderWidth(layerTreeImpl());
} else if (iter->priority(ACTIVE_TREE).resolution == LOW_RESOLUTION) {
@@ -152,12 +155,23 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
layerDeviceAlignment);
iter;
++iter) {
- ResourceProvider::ResourceId resource = 0;
- if (*iter)
- resource = iter->GetResourceId();
gfx::Rect geometry_rect = iter.geometry_rect();
+ ResourceProvider::ResourceId resource = 0;
+ if (*iter) {
+ if (iter->is_solid_color()) {
+ scoped_ptr<SolidColorDrawQuad> quad = SolidColorDrawQuad::Create();
+ quad->SetNew(sharedQuadState, geometry_rect, iter->solid_color());
+ quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData);
+ if (!seen_tilings.size() || seen_tilings.back() != iter.CurrentTiling())
+ seen_tilings.push_back(iter.CurrentTiling());
+ continue;
+ } else if (iter->is_transparent()) {
+ continue;
+ }
+ resource = iter->GetResourceId();
+ }
if (!resource) {
if (drawCheckerboardForMissingTiles()) {
// TODO(enne): Figure out how to show debug "invalidated checker" color
@@ -509,7 +523,7 @@ bool PictureLayerImpl::areVisibleResourcesReady() const {
iter;
++iter) {
// A null tile (i.e. no recording) is considered "ready".
- if (!*iter || iter->GetResourceId())
+ if (!*iter || iter->IsReadyToDraw())
missing_region.Subtract(iter.geometry_rect());
}
}
« no previous file with comments | « cc/picture.cc ('k') | cc/picture_layer_tiling_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698