cc: Consolidate the analysis_canvas operations

cc/picture_pile_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_PICTURE_PILE_IMPL_H_
 #define CC_PICTURE_PILE_IMPL_H_
 
 #include <list>
 #include <map>
 
 #include "base/threading/thread.h"
 #include "cc/cc_export.h"
 #include "cc/picture_pile_base.h"
 #include "skia/ext/refptr.h"
 #include "third_party/skia/include/core/SkPicture.h"
 
 namespace cc {
 struct RenderingStats;
 
 class CC_EXPORT PicturePileImpl : public PicturePileBase {
  public:
+
+  class Analysis {

[reveman, 2013/02/28 21:23:10]

can we move this or just use the Picture::Analysis struct? I'd prefer to just
have one struct.

+    public:
+      Analysis();
+
+      bool is_solid_color() const {
+        return is_analyzed_ && is_solid_color_;
+      }
+
+      SkColor get_solid_color() const {
+        DCHECK(is_solid_color());
+        return solid_color_;
+      }
+
+      bool is_transparent() const {
+        return is_analyzed_ && is_transparent_;
+      }
+
+      bool is_cheap_to_raster() const {
+        return is_analyzed_ && is_cheap_to_raster_;
+      }
+
+    private:
+      friend class PicturePileImpl;
+
+      bool is_solid_color_;
+      bool is_transparent_;
+      bool is_cheap_to_raster_;
+      bool is_analyzed_;

[reveman, 2013/02/28 21:23:10]

why do you need this flag? can't you just initialize is_solid_color_,
is_transparent_... properly to get the same result?

+      SkColor solid_color_;
+  };
+
   static scoped_refptr<PicturePileImpl> Create();
 
   // Get paint-safe version of this picture for a specific thread.
   PicturePileImpl* GetCloneForDrawingOnThread(base::Thread*);
 
   // Clone a paint-safe version of this picture.
   scoped_refptr<PicturePileImpl> CloneForDrawing() const;
 
   // Raster a subrect of this PicturePileImpl into the given canvas.
   // It's only safe to call paint on a cloned version.
@@ skipping 10 matching lines @@
       std::list<skia::LazyPixelRef*>& pixel_refs);
 
   void PushPropertiesTo(PicturePileImpl* other);
 
   skia::RefPtr<SkPicture> GetFlattenedPicture();
 
   void set_slow_down_raster_scale_factor(int factor) {
     slow_down_raster_scale_factor_for_debug_ = factor;
   }
 
-  bool IsCheapInRect(gfx::Rect content_rect, float contents_scale) const;
+  void AnalyzeInRect(const gfx::Rect& content_rect,
+                     float contents_scale,
+                     Analysis* analysis);
 
  protected:
   friend class PicturePile;
 
   PicturePileImpl();
   virtual ~PicturePileImpl();
 
   typedef std::map<base::PlatformThreadId, scoped_refptr<PicturePileImpl> >
       CloneMap;
   CloneMap clones_;
 
   int slow_down_raster_scale_factor_for_debug_;
 
   DISALLOW_COPY_AND_ASSIGN(PicturePileImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_PICTURE_PILE_IMPL_H_