Move HostKeyPair into protocol::KeyPair.

remoting/base/rsa_key_pair.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_BASE_RSA_KEY_PAIR_H_
+#define REMOTING_BASE_RSA_KEY_PAIR_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+
+namespace crypto {
+class RSAPrivateKey;
+}  // namespace crypto
+
+namespace remoting {
+
+class RsaKeyPair : public base::RefCountedThreadSafe<RsaKeyPair> {
+ public:
+  RsaKeyPair();
+
+  // Generates a new (random) private key from scratch.

[Wez, 2013/03/06 00:43:25]

nit: No need for both "from scratch" and "(random)"

[rmsousa, 2013/03/06 04:36:49]

Done.

+  void Generate();
+
+  // Loads a private key from a base64-encoded string. Returns true on success.
+  bool LoadFromString(const std::string& key_base64);

[Wez, 2013/03/06 00:43:25]

Looking at the call-sites, can this be static scoped_refptr<> FromString(), and
similarly for Generate(), above?

[rmsousa, 2013/03/06 04:36:49]

Done.

+  // Returns a base64 encoded string representing the private key.

[Wez, 2013/03/06 00:43:25]

Blank line before this comment.

[rmsousa, 2013/03/06 04:36:49]

Done.

+  std::string GetAsString() const;

[Wez, 2013/03/06 00:43:25]

nit: ToString()

[rmsousa, 2013/03/06 04:36:49]

Done.

+
+  // Generates a DER-encoded self-signed certificate using the key pair. Returns
+  // empty string if cert generation fails (e.g. it may happen when the system
+  // clock is off).
+  std::string GenerateCertificate() const;
+  // Returns a base64-encoded string representing the public key.

[Wez, 2013/03/06 00:43:25]

nit: Blank line before this comment.

[rmsousa, 2013/03/06 04:36:49]

Done.

+  std::string GetPublicKey() const;
+  // Returns a base64-encoded signature for the message.

[Wez, 2013/03/06 00:43:25]

nit: Blank line before this comment.

[rmsousa, 2013/03/06 04:36:49]

Done.

+  std::string GetSignature(const std::string& message) const;
+
+  crypto::RSAPrivateKey* private_key() { return key_.get(); }

[Wez, 2013/03/06 00:43:25]

nit: const?

[rmsousa, 2013/03/06 04:36:49]

The SSL APIs don't take const parameters. I'm not sure if they actually touch
the key, or if it's just because it's pure-C underneath, but in any case, I
prefer to leave it as non-const than to cast it away on the call site (casting
const away is fairly evil, in general)

+
+ private:
+  friend class base::RefCountedThreadSafe<RsaKeyPair>;
+  virtual ~RsaKeyPair();
+
+  scoped_ptr<crypto::RSAPrivateKey> key_;
+
+  DISALLOW_COPY_AND_ASSIGN(RsaKeyPair);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_BASE_RSA_KEY_PAIR_H_