chrome/common/extensions/extension_manifest_constants.h - Issue 12316077: Move the parsing of app.launch related keys out of Extension class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_manifest_constants.h

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + review comments addressed Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/app_launcher_info.cc ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_manifest_constants.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_manifest_constants.h

diff --git a/chrome/common/extensions/extension_manifest_constants.h b/chrome/common/extensions/extension_manifest_constants.h

index e21abdb860e436a739ac639589339433d981cd16..c68ddce3f69fd71a4b2c5055b3ab01be129456a6 100644

--- a/chrome/common/extensions/extension_manifest_constants.h

+++ b/chrome/common/extensions/extension_manifest_constants.h

@@ -67,10 +67,6 @@ namespace extension_manifest_keys {

extern const char kLaunchContainer[];

extern const char kLaunchHeight[];

extern const char kLaunchLocalPath[];

- extern const char kLaunchMaxHeight[];

- extern const char kLaunchMaxWidth[];

- extern const char kLaunchMinHeight[];

- extern const char kLaunchMinWidth[];

extern const char kLaunchWebURL[];

extern const char kLaunchWidth[];

extern const char kLayouts[];