chrome/browser/extensions/api/management/management_api.cc - Issue 12316077: Move the parsing of app.launch related keys out of Extension class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + review comments addressed Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/app_launch_manifest_parser.h » ('j') | chrome/browser/extensions/app_launch_manifest_parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index b788c99ded8408de572297257cd2c38c947dec1b..c7ca3aef2111392d41ada9cd0288d8247370d4fb 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -32,6 +32,7 @@

#include "chrome/common/chrome_utility_messages.h"

#include "chrome/common/extensions/api/icons/icons_handler.h"

#include "chrome/common/extensions/api/management.h"

+#include "chrome/common/extensions/app_launcher_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

@@ -136,7 +137,7 @@ scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(

if (extension.is_app()) {

info->app_launch_url.reset(new std::string(

- extension.GetFullLaunchURL().spec()));

+ AppLauncherInfo::GetFullLaunchURL(&extension).spec()));

}

const ExtensionIconSet::IconMap& icons =