Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + review comments addressed Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/web_applications/web_app_ui.h" 5 #include "chrome/browser/ui/web_applications/web_app_ui.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
11 #include "base/string16.h" 11 #include "base/string16.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "chrome/browser/extensions/image_loader.h" 13 #include "chrome/browser/extensions/image_loader.h"
14 #include "chrome/browser/extensions/tab_helper.h" 14 #include "chrome/browser/extensions/tab_helper.h"
15 #include "chrome/browser/favicon/favicon_tab_helper.h" 15 #include "chrome/browser/favicon/favicon_tab_helper.h"
16 #include "chrome/browser/favicon/favicon_util.h" 16 #include "chrome/browser/favicon/favicon_util.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/web_applications/web_app.h" 18 #include "chrome/browser/web_applications/web_app.h"
19 #include "chrome/common/chrome_notification_types.h" 19 #include "chrome/common/chrome_notification_types.h"
20 #include "chrome/common/extensions/api/icons/icons_handler.h" 20 #include "chrome/common/extensions/api/icons/icons_handler.h"
21 #include "chrome/common/extensions/app_launcher_info.h"
21 #include "chrome/common/extensions/extension.h" 22 #include "chrome/common/extensions/extension.h"
22 #include "content/public/browser/browser_thread.h" 23 #include "content/public/browser/browser_thread.h"
23 #include "content/public/browser/notification_details.h" 24 #include "content/public/browser/notification_details.h"
24 #include "content/public/browser/notification_registrar.h" 25 #include "content/public/browser/notification_registrar.h"
25 #include "content/public/browser/notification_source.h" 26 #include "content/public/browser/notification_source.h"
26 #include "content/public/browser/web_contents.h" 27 #include "content/public/browser/web_contents.h"
27 #include "googleurl/src/gurl.h" 28 #include "googleurl/src/gurl.h"
28 #include "grit/theme_resources.h" 29 #include "grit/theme_resources.h"
29 #include "skia/ext/image_operations.h" 30 #include "skia/ext/image_operations.h"
30 #include "third_party/skia/include/core/SkBitmap.h" 31 #include "third_party/skia/include/core/SkBitmap.h"
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 UpdateShortcutWorker* worker = new UpdateShortcutWorker(web_contents); 381 UpdateShortcutWorker* worker = new UpdateShortcutWorker(web_contents);
381 worker->Run(); 382 worker->Run();
382 #endif // defined(OS_WIN) 383 #endif // defined(OS_WIN)
383 } 384 }
384 385
385 void UpdateShortcutInfoForApp(const extensions::Extension& app, 386 void UpdateShortcutInfoForApp(const extensions::Extension& app,
386 Profile* profile, 387 Profile* profile,
387 ShellIntegration::ShortcutInfo* shortcut_info) { 388 ShellIntegration::ShortcutInfo* shortcut_info) {
388 shortcut_info->extension_id = app.id(); 389 shortcut_info->extension_id = app.id();
389 shortcut_info->is_platform_app = app.is_platform_app(); 390 shortcut_info->is_platform_app = app.is_platform_app();
390 shortcut_info->url = GURL(app.launch_web_url()); 391 shortcut_info->url = GURL(extensions::AppLauncherInfo::GetLaunchWebURL(&app));
391 shortcut_info->title = UTF8ToUTF16(app.name()); 392 shortcut_info->title = UTF8ToUTF16(app.name());
392 shortcut_info->description = UTF8ToUTF16(app.description()); 393 shortcut_info->description = UTF8ToUTF16(app.description());
393 shortcut_info->extension_path = app.path(); 394 shortcut_info->extension_path = app.path();
394 shortcut_info->profile_path = profile->GetPath(); 395 shortcut_info->profile_path = profile->GetPath();
395 } 396 }
396 397
397 void UpdateShortcutInfoAndIconForApp( 398 void UpdateShortcutInfoAndIconForApp(
398 const extensions::Extension& extension, 399 const extensions::Extension& extension,
399 Profile* profile, 400 Profile* profile,
400 const web_app::ShortcutInfoCallback& callback) { 401 const web_app::ShortcutInfoCallback& callback) {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 } 437 }
437 438
438 // |info_list| may still be empty at this point, in which case LoadImage 439 // |info_list| may still be empty at this point, in which case LoadImage
439 // will call the OnImageLoaded callback with an empty image and exit 440 // will call the OnImageLoaded callback with an empty image and exit
440 // immediately. 441 // immediately.
441 extensions::ImageLoader::Get(profile)->LoadImagesAsync(&extension, info_list, 442 extensions::ImageLoader::Get(profile)->LoadImagesAsync(&extension, info_list,
442 base::Bind(&OnImageLoaded, shortcut_info, callback)); 443 base::Bind(&OnImageLoaded, shortcut_info, callback));
443 } 444 }
444 445
445 } // namespace web_app 446 } // namespace web_app
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698