Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/extensions/extension_prefs.cc

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + review comments addressed Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_prefs.h" 5 #include "chrome/browser/extensions/extension_prefs.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_notifier.h" 8 #include "base/prefs/pref_notifier.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "base/version.h" 13 #include "base/version.h"
14 #include "chrome/browser/extensions/admin_policy.h" 14 #include "chrome/browser/extensions/admin_policy.h"
15 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h" 15 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h"
16 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h" 16 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
17 #include "chrome/browser/extensions/extension_pref_store.h" 17 #include "chrome/browser/extensions/extension_pref_store.h"
18 #include "chrome/browser/extensions/extension_sorting.h" 18 #include "chrome/browser/extensions/extension_sorting.h"
19 #include "chrome/browser/prefs/pref_registry_syncable.h" 19 #include "chrome/browser/prefs/pref_registry_syncable.h"
20 #include "chrome/browser/prefs/scoped_user_pref_update.h" 20 #include "chrome/browser/prefs/scoped_user_pref_update.h"
21 #include "chrome/common/chrome_notification_types.h" 21 #include "chrome/common/chrome_notification_types.h"
22 #include "chrome/common/chrome_switches.h" 22 #include "chrome/common/chrome_switches.h"
23 #include "chrome/common/chrome_version_info.h" 23 #include "chrome/common/chrome_version_info.h"
24 #include "chrome/common/extensions/app_launcher_info.h"
24 #include "chrome/common/extensions/feature_switch.h" 25 #include "chrome/common/extensions/feature_switch.h"
25 #include "chrome/common/extensions/manifest.h" 26 #include "chrome/common/extensions/manifest.h"
26 #include "chrome/common/extensions/permissions/permission_set.h" 27 #include "chrome/common/extensions/permissions/permission_set.h"
27 #include "chrome/common/extensions/permissions/permissions_info.h" 28 #include "chrome/common/extensions/permissions/permissions_info.h"
28 #include "chrome/common/pref_names.h" 29 #include "chrome/common/pref_names.h"
29 #include "chrome/common/url_constants.h" 30 #include "chrome/common/url_constants.h"
30 #include "content/public/browser/notification_service.h" 31 #include "content/public/browser/notification_service.h"
31 #include "extensions/common/url_pattern.h" 32 #include "extensions/common/url_pattern.h"
32 #include "grit/generated_resources.h" 33 #include "grit/generated_resources.h"
33 #include "ui/base/l10n/l10n_util.h" 34 #include "ui/base/l10n/l10n_util.h"
(...skipping 1237 matching lines...) Expand 10 before | Expand all | Expand 10 after
1271 result = LAUNCH_REGULAR; 1272 result = LAUNCH_REGULAR;
1272 #endif // OS_WIN 1273 #endif // OS_WIN
1273 1274
1274 return result; 1275 return result;
1275 } 1276 }
1276 1277
1277 extension_misc::LaunchContainer ExtensionPrefs::GetLaunchContainer( 1278 extension_misc::LaunchContainer ExtensionPrefs::GetLaunchContainer(
1278 const Extension* extension, 1279 const Extension* extension,
1279 ExtensionPrefs::LaunchType default_pref_value) { 1280 ExtensionPrefs::LaunchType default_pref_value) {
1280 extension_misc::LaunchContainer manifest_launch_container = 1281 extension_misc::LaunchContainer manifest_launch_container =
1281 extension->launch_container(); 1282 AppLauncherInfo::GetLaunchContainer(extension);
1282 1283
1283 const extension_misc::LaunchContainer kInvalidLaunchContainer = 1284 const extension_misc::LaunchContainer kInvalidLaunchContainer =
1284 static_cast<extension_misc::LaunchContainer>(-1); 1285 static_cast<extension_misc::LaunchContainer>(-1);
1285 1286
1286 extension_misc::LaunchContainer result = kInvalidLaunchContainer; 1287 extension_misc::LaunchContainer result = kInvalidLaunchContainer;
1287 1288
1288 if (manifest_launch_container == extension_misc::LAUNCH_PANEL) { 1289 if (manifest_launch_container == extension_misc::LAUNCH_PANEL) {
1289 // Apps with app.launch.container = 'panel' should always respect the 1290 // Apps with app.launch.container = 'panel' should always respect the
1290 // manifest setting. 1291 // manifest setting.
1291 result = manifest_launch_container; 1292 result = manifest_launch_container;
(...skipping 1142 matching lines...) Expand 10 before | Expand all | Expand 10 after
2434 is_enabled = initial_state == Extension::ENABLED; 2435 is_enabled = initial_state == Extension::ENABLED;
2435 } 2436 }
2436 2437
2437 extension_pref_value_map_->RegisterExtension(extension_id, install_time, 2438 extension_pref_value_map_->RegisterExtension(extension_id, install_time,
2438 is_enabled); 2439 is_enabled);
2439 content_settings_store_->RegisterExtension(extension_id, install_time, 2440 content_settings_store_->RegisterExtension(extension_id, install_time,
2440 is_enabled); 2441 is_enabled);
2441 } 2442 }
2442 2443
2443 } // namespace extensions 2444 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698