Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: tests/standalone/io/raw_secure_server_socket_test.dart

Issue 12316071: dart:io Improve raw_secure_server_socket_test to pin down problem. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_secure_server_socket_test.dart
diff --git a/tests/standalone/io/raw_secure_server_socket_test.dart b/tests/standalone/io/raw_secure_server_socket_test.dart
index 98559d0c1c782946a2bad1b3c3fdd7cc8a9d52f6..73609ae12d92f342808f92526f93ffd6bb9f4dae 100644
--- a/tests/standalone/io/raw_secure_server_socket_test.dart
+++ b/tests/standalone/io/raw_secure_server_socket_test.dart
@@ -171,8 +171,14 @@ void testSimpleReadWrite() {
Expect.isTrue(bytesWritten == 0);
Expect.isTrue(client.available() > 0);
var buffer = client.read();
- data.setRange(bytesRead, buffer.length, buffer);
- bytesRead += buffer.length;
+ if (buffer != null) {
+ data.setRange(bytesRead, buffer.length, buffer);
+ bytesRead += buffer.length;
+ for (var value in buffer) {
+ Expect.isTrue(value is int);
+ Expect.isTrue(value < 256 && value >= 0);
+ }
+ }
if (bytesRead == data.length) {
verifyTestData(data);
client.writeEventsEnabled = true;
@@ -180,6 +186,11 @@ void testSimpleReadWrite() {
break;
case RawSocketEvent.WRITE:
Expect.isFalse(client.writeEventsEnabled);
+ Expect.equals(bytesRead, data.length);
+ for (int i = bytesWritten; i < data.length; ++i) {
+ Expect.isTrue(data[i] is int);
+ Expect.isTrue(data[i] < 256 && data[i] >= 0);
+ }
bytesWritten += client.write(
data, bytesWritten, data.length - bytesWritten);
if (bytesWritten < data.length) {
@@ -207,8 +218,10 @@ void testSimpleReadWrite() {
case RawSocketEvent.READ:
Expect.isTrue(socket.available() > 0);
var buffer = socket.read();
- dataReceived.setRange(bytesRead, buffer.length, buffer);
- bytesRead += buffer.length;
+ if (buffer != null) {
+ dataReceived.setRange(bytesRead, buffer.length, buffer);
+ bytesRead += buffer.length;
+ }
break;
case RawSocketEvent.WRITE:
Expect.isTrue(bytesRead == 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698