Fixed problem with non-void return types in IDL

Fixed problem with non-void return types in IDL

Allowed non-void return types to be interpreted correctly from IDL.

Also updated Dart generator to interpret these new types correctly.

BUG=144301

[not at google - send to devlin, 2013-02-21 03:46:03]

lgtm, I'll take your word that the generated dart is correct...

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
File tools/json_schema_compiler/dart_generator.py (right):

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator.py:644: return name[len(prefix):]
seems like len(prefix) is just len(self._namespace.name.replace('.', ''))

it's not called though...

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:91: a name/value pair, where the value
is a tuple of:
could you return (name, parameters, return value) instead of a nested tuple?

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:104: {'name':
self.node.GetName()}).process(callbacks)
indentation is wonky

[sashab, 2013-02-21 22:15:03]

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
File tools/json_schema_compiler/dart_generator.py (right):

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator.py:644: return name[len(prefix):]
On 2013/02/21 03:46:03, kalman wrote:
> seems like len(prefix) is just len(self._namespace.name.replace('.', ''))
> 
> it's not called though...

Done.

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:91: a name/value pair, where the value
is a tuple of:
On 2013/02/21 03:46:03, kalman wrote:
> could you return (name, parameters, return value) instead of a nested tuple?

Done.

https://codereview.chromium.org/12316031/diff/1003/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:104: {'name':
self.node.GetName()}).process(callbacks)
On 2013/02/21 03:46:03, kalman wrote:
> indentation is wonky

Done.

[commit-bot: I haz the power, 2013-02-21 22:30:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12316031/8001

[commit-bot: I haz the power, 2013-02-22 01:17:55]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-02-22 18:22:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12316031/8001

[commit-bot: I haz the power, 2013-02-22 20:09:24]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-25 04:33:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sashab@chromium.org/12316031/8001

[benwells, 2013-02-25 04:35:23]

Looks like test failures are real.

https://codereview.chromium.org/12316031/diff/8001/tools/json_schema_compiler...
File tools/json_schema_compiler/dart_generator.py (right):

https://codereview.chromium.org/12316031/diff/8001/tools/json_schema_compiler...
tools/json_schema_compiler/dart_generator.py:230: (type_name, type_name,
prop.name, type_name, prop.name))
This doesn't look right. I think the second and third sub should be swapped.