Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java

Issue 12316003: Fix tests compilation (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: format Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java
index 89505ecf337df098443163e9a51458ae3a7c2cf6..65b018af170faf7f0bde6f87a3e7318b84f93a32 100755
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptManager.java
@@ -16,7 +16,6 @@ import java.util.Map;
import org.chromium.sdk.Script;
import org.chromium.sdk.Script.Type;
-import org.chromium.sdk.internal.ScriptBase;
import org.chromium.sdk.internal.ScriptBase.Descriptor;
import org.chromium.sdk.internal.v8native.protocol.V8ProtocolUtil;
import org.chromium.sdk.internal.v8native.protocol.input.data.ScriptHandle;
@@ -61,8 +60,15 @@ public class ScriptManager {
* a valid script JSON
*/
public Script addScript(ScriptHandle scriptBody, List<SomeHandle> refs) {
- ScriptImpl theScript = findById(V8ProtocolUtil.getScriptIdFromResponse(scriptBody));
+ ScriptImpl theScript = addScriptImpl(scriptBody, refs);
+ if (theScript != null) {
+ debugSession.getSessionManager().getDebugEventListener().scriptLoaded(theScript);
+ }
+ return theScript;
+ }
+ ScriptImpl addScriptImpl(ScriptHandle scriptBody, List<SomeHandle> refs) {
+ ScriptImpl theScript = findById(V8ProtocolUtil.getScriptIdFromResponse(scriptBody));
synchronized (this) {
if (theScript == null) {
Descriptor<Long> desc = createDescriptor(scriptBody, refs, contextFilter);
@@ -76,8 +82,6 @@ public class ScriptManager {
setSourceCode(scriptBody, theScript);
}
}
-
- debugSession.getSessionManager().getDebugEventListener().scriptLoaded(theScript);
return theScript;
}

Powered by Google App Engine
This is Rietveld 408576698