Add some browser tests for the cast system tray.

chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/shell.h"
+#include "ash/system/cast/tray_cast.h"
+#include "ash/system/tray/system_tray.h"
+#include "ash/system/tray/system_tray_delegate.h"
+#include "ash/system/tray/system_tray_item.h"
+#include "ash/test/tray_cast_test_api.h"
+#include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/test/test_utils.h"
+#include "extensions/browser/process_manager.h"
+
+namespace {
+
+// Execute JavaScript within the context of the extension. Returns the result
+// of the execution.
+scoped_ptr<base::Value> ExecuteJavaScript(
+    const extensions::Extension* extension,
+    const std::string& javascript) {
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  auto pm = extensions::ProcessManager::Get(profile);
+  content::RenderViewHost* host =
+      pm->GetBackgroundHostForExtension(extension->id())->render_view_host();
+  return content::ExecuteScriptAndGetValue(host->GetMainFrame(), javascript);
+}
+
+// Ensures that all pending JavaScript execution callbacks are invoked.
+void ExecutePendingJavaScript(const extensions::Extension* extension) {
+  ExecuteJavaScript(extension, "");

[oshima, 2015/07/20 23:07:04]

std::string()

[jdufault, 2015/07/21 19:52:44]

Done.

+}
+
+// Invokes tray->StartCast(id) and verifies that launchDesktopMirroring
+// was called with the same id. This automatically creates/destroys the detail
+// view and notifies the tray that Chrome has begun casting.
+void StartCastWithVerification(const extensions::Extension* extension,
+                               ash::TrayCast* tray,
+                               const std::string& receiver_id) {
+  ash::SystemTrayItem* system_tray_item = tray;

[oshima, 2015/07/20 23:07:03]

is there particular reason why you want to have this separate variable?

[jdufault, 2015/07/21 19:52:44]

Yes, the API has private visibility in ash::TrayCast.

[oshima, 2015/07/21 21:21:04]

Acknowledged.

+  ash::TrayCastTestAPI test_tray(tray);
+
+  // StartCast will simulate a button click in the detail view to begin
+  // the cast, so we need to make a detail view available.
+  system_tray_item->CreateDetailedView(ash::user::LoginStatus::LOGGED_IN_USER);
+
+  // Clear out any old state and execute any pending JS calls created from the
+  // CreateDetailedView call.
+  ExecuteJavaScript(extension, "launchDesktopMirroringReceiverId = ''");
+
+  test_tray.StartCast(receiver_id);
+
+  scoped_ptr<base::Value> get_launch_desktop_mirroring_id =
+      ExecuteJavaScript(extension, "getLaunchDesktopMirroringReceiverId()");
+  std::string result;
+  EXPECT_TRUE(get_launch_desktop_mirroring_id->GetAsString(&result));
+  EXPECT_EQ(receiver_id, result);

[oshima, 2015/07/20 23:07:04]

EXPECT in a utility function makes it difficult to understand in which step it's
failing. Looks like the 1st EXPECT_TRUE is actually an assert, and the 2nd can
be returned as a boolean and the caller can test?

[jdufault, 2015/07/21 19:52:44]

Done.

+  system_tray_item->DestroyDetailedView();
+
+  // Tell the tray item that Chrome has started casting.
+  test_tray.OnCastingSessionStartedOrStopped(true);
+  ExecutePendingJavaScript(extension);
+}
+
+// Invokes tray->StopCast() and verifies that stopMirroring('user-stop')
+// got called in the extension.
+void StopCastWithVerification(const extensions::Extension* extension,
+                              ash::TrayCastTestAPI* tray) {
+  ExecuteJavaScript(extension, "stopMirroringCalled = false");
+  tray->StopCast();
+  scoped_ptr<base::Value> wasStopMirroringCalled =
+      ExecuteJavaScript(extension, "wasStopMirroringCalledWithUserStop()");
+  bool result;
+  EXPECT_TRUE(wasStopMirroringCalled->GetAsBoolean(&result));
+  EXPECT_TRUE(result);

[oshima, 2015/07/20 23:07:03]

ditto

[jdufault, 2015/07/21 19:52:44]

Done.

+
+  // Tell the tray item that Chrome has stopped casting.
+  tray->OnCastingSessionStartedOrStopped(false);
+  ExecutePendingJavaScript(extension);
+}
+
+// Returns the cast tray. The tray initializer may have launched some
+// JavaScript callbacks which have not finished executing.
+ash::TrayCast* GetTrayCast(const extensions::Extension* extension) {
+  ash::SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
+  // Make sure we actually popup the tray, otherwise the TrayCast instance will
+  // not be created.
+  tray->ShowDefaultView(ash::BubbleCreationType::BUBBLE_CREATE_NEW);
+
+  // Creating the tray causes some JavaScript to be executed. Let's try to make
+  // sure it is completed.
+  if (extension)
+    ExecutePendingJavaScript(extension);
+
+  return tray->GetTrayCastForTesting();
+}
+
+class SystemTrayTrayCastChromeOSTest : public ExtensionBrowserTest {
+ protected:
+  SystemTrayTrayCastChromeOSTest() : ExtensionBrowserTest() {}
+  ~SystemTrayTrayCastChromeOSTest() override {}
+
+  const extensions::Extension* LoadCastTestExtension() {
+    return LoadExtension(test_data_dir_.AppendASCII("tray_cast"));
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SystemTrayTrayCastChromeOSTest);
+};
+
+// A simple sanity check to make sure that the cast config delegate actually
+// recognizes the cast extension.
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTraySanityCheckTestExtensionGetsRecognized) {
+  ash::CastConfigDelegate* cast_config_delegate =
+    ash::Shell::GetInstance()->system_tray_delegate()->GetCastConfigDelegate();
+
+  EXPECT_FALSE(cast_config_delegate->HasCastExtension());
+  LoadCastTestExtension();
+  EXPECT_TRUE(cast_config_delegate->HasCastExtension());
+}
+
+// Verifies that the cast tray is hidden when there is no extension installed.
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayIsHiddenWhenThereIsNoExtension) {
+  ash::TrayCastTestAPI tray(GetTrayCast(nullptr));
+  EXPECT_TRUE(tray.IsTrayInitialized());
+  EXPECT_FALSE(tray.IsTrayVisible());
+}
+
+// Verifies that the cast tray is hidden if there are no available receivers,
+// even if there is an extension installed.
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayIsHiddenWhenThereIsAnExtensionButNoReceivers) {
+  const extensions::Extension* extension = LoadCastTestExtension();
+
+  ash::TrayCastTestAPI tray(GetTrayCast(extension));
+  EXPECT_TRUE(tray.IsTrayInitialized());
+  EXPECT_FALSE(tray.IsTrayVisible());
+}
+
+// Verifies that the cast tray is displayed when there are receivers available.
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayIsDisplayedWhenThereIsAnExtensionWithReceivers) {
+  const extensions::Extension* extension = LoadCastTestExtension();
+  ExecuteJavaScript(extension, "addReceiver('test_id', 'name')");
+
+  ash::TrayCastTestAPI tray(GetTrayCast(extension));
+
+  EXPECT_TRUE(tray.IsTrayInitialized());
+  EXPECT_TRUE(tray.IsTrayVisible());
+}
+
+// Verifies that we can cast to a specific receiver, stop casting, and then cast
+// to another receiver when there is more than one receiver
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayMultipleReceivers) {
+  const extensions::Extension* extension = LoadCastTestExtension();
+  ExecuteJavaScript(extension, "addReceiver('test_id_1', 'name')");
+  ExecuteJavaScript(extension, "addReceiver('not_used_0', 'name1')");
+  ExecuteJavaScript(extension, "addReceiver('test_id_0', 'name')");
+  ExecuteJavaScript(extension, "addReceiver('not_used_1', 'name2')");
+
+  ash::TrayCast* tray = GetTrayCast(extension);
+  ash::TrayCastTestAPI test_tray(tray);
+  StartCastWithVerification(extension, tray, "test_id_0");
+
+  EXPECT_TRUE(test_tray.IsTrayCastViewVisible());
+  StopCastWithVerification(extension, &test_tray);
+  EXPECT_TRUE(test_tray.IsTraySelectViewVisible());
+
+  StartCastWithVerification(extension, tray, "test_id_1");
+  EXPECT_TRUE(test_tray.IsTrayCastViewVisible());
+  StopCastWithVerification(extension, &test_tray);
+  EXPECT_TRUE(test_tray.IsTraySelectViewVisible());
+}
+
+// Verifies the stop cast button invokes the JavaScript function
+// "stopMirroring('user-stop')".
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayStopButtonStopsCast) {
+  // Add a receiver that is casting.
+  const extensions::Extension* extension = LoadCastTestExtension();
+  ExecuteJavaScript(extension, "addReceiver('test_id', 'name', 'title', 1)");
+
+  ash::TrayCastTestAPI test_tray(GetTrayCast(extension));
+  test_tray.OnCastingSessionStartedOrStopped(true);
+  ExecutePendingJavaScript(extension);
+  EXPECT_TRUE(test_tray.IsTrayCastViewVisible());
+
+  // Stop the cast using the UI.
+  StopCastWithVerification(extension, &test_tray);
+  EXPECT_TRUE(test_tray.IsTraySelectViewVisible());
+}
+
+// Verifies that the start cast button invokes "launchDesktopMirroring(...)".
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest,
+                       CastTrayStartButtonStartsCast) {
+  const extensions::Extension* extension = LoadCastTestExtension();
+  ExecuteJavaScript(extension, "addReceiver('test_id', 'name')");
+  ash::TrayCast* tray = GetTrayCast(extension);
+  StartCastWithVerification(extension, tray, "test_id");
+}
+
+// Verifies that the CastConfigDelegate opens up a tab called "options.html".
+IN_PROC_BROWSER_TEST_F(SystemTrayTrayCastChromeOSTest, CastTrayOpenOptions) {
+  LoadCastTestExtension();
+
+  ash::CastConfigDelegate* cast_config_delegate =
+    ash::Shell::GetInstance()->system_tray_delegate()->GetCastConfigDelegate();
+  cast_config_delegate->LaunchCastOptions();
+
+  const GURL url =
+      browser()->tab_strip_model()->GetActiveWebContents()->GetURL();
+  EXPECT_TRUE(base::StringPiece(url.GetContent()).ends_with("options.html"));
+}
+
+}  // namespace

[oshima, 2015/07/20 23:07:04]

we usually put the test bodies outside of anonymous for couple of reasons:

1) tests names are supposed to be unique (so that gtest_filter will not
conflict)
2) you can't make them friend.

[jdufault, 2015/07/21 19:52:44]

Done.