Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1231533002: Deprecate Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
937 937
938 case MediaStreamStop: 938 case MediaStreamStop:
939 return "'MediaStream.stop()' is deprecated and will be removed in M47, a round November 2015. Please use 'MediaStream.active' instead."; 939 return "'MediaStream.stop()' is deprecated and will be removed in M47, a round November 2015. Please use 'MediaStream.active' instead.";
940 940
941 case MediaStreamEnded: 941 case MediaStreamEnded:
942 return "'MediaStream.ended' is deprecated and will be removed in M47, ar ound November 2015. Please use 'MediaStream.active' instead."; 942 return "'MediaStream.ended' is deprecated and will be removed in M47, ar ound November 2015. Please use 'MediaStream.active' instead.";
943 943
944 case PermissionStatusStatus: 944 case PermissionStatusStatus:
945 return "PermissionStatus.status is deprecated and will be removed in M47 , around November 2015. Please use PermissionStatus.state instead."; 945 return "PermissionStatus.status is deprecated and will be removed in M47 , around November 2015. Please use PermissionStatus.state instead.";
946 946
947 case ElementOffsetParent:
948 return "'Element.offsetParent' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely s upported for HTML elements.";
949
950 case ElementOffsetTop:
951 return "'Element.offsetTop' is deprecated and will be removed in M47, ar ound Novemver 2015. The offset* attributes are only standardized and widely supp orted for HTML elements.";
952
953 case ElementOffsetLeft:
954 return "'Element.offsetLeft' is deprecated and will be removed in M47, a round Novemver 2015. The offset* attributes are only standardized and widely sup ported for HTML elements.";
955
956 case ElementOffsetWidth:
957 return "'Element.offsetWidth' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely su pported for HTML elements.";
958
959 case ElementOffsetHeight:
960 return "'Element.offsetHeight' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely s upported for HTML elements.";
961
947 // Features that aren't deprecated don't have a deprecation message. 962 // Features that aren't deprecated don't have a deprecation message.
948 default: 963 default:
949 return String(); 964 return String();
950 } 965 }
951 } 966 }
952 967
953 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 968 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
954 { 969 {
955 ASSERT(feature >= firstCSSProperty); 970 ASSERT(feature >= firstCSSProperty);
956 ASSERT(feature <= lastUnresolvedCSSProperty); 971 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
984 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 999 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
985 { 1000 {
986 // FIXME: We may want to handle stylesheets that have multiple owners 1001 // FIXME: We may want to handle stylesheets that have multiple owners
987 // http://crbug.com/242125 1002 // http://crbug.com/242125
988 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1003 if (sheetContents && sheetContents->hasSingleOwnerNode())
989 return getFrom(sheetContents->singleOwnerDocument()); 1004 return getFrom(sheetContents->singleOwnerDocument());
990 return 0; 1005 return 0;
991 } 1006 }
992 1007
993 } // namespace blink 1008 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698