Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 12315138: Only print error message in debug mode. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 9 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Only print error message in debug mode. Currently, PictureTest runs a test of recording a bad bitmap to a picture and then replaying the picture. We assert at the record step in debug mode, so the test only runs in release, to ensure that we can still play back a picture, even if it has a bad bitmap. Silence the error message in release, so our test doesn't appear to error (since it is actually working as desired). Committed: https://code.google.com/p/skia/source/detail?r=7897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkPicturePlayback.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
7 years, 9 months ago (2013-02-27 20:36:55 UTC) #1
reed1
lgtm Makes we wonder (again) if we can invent a cool way to capture errors/warnings/failures ...
7 years, 9 months ago (2013-02-27 20:39:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12315138/1
7 years, 9 months ago (2013-02-27 20:42:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 12315138-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-27 20:42:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12315138/1
7 years, 9 months ago (2013-02-27 20:44:32 UTC) #5
commit-bot: I haz the power
Presubmit check for 12315138-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-27 20:44:33 UTC) #6
scroggo
7 years, 9 months ago (2013-02-28 15:50:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r7897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698