Make sure .RC file including elevated_controller.tlb is rebuilt every time .TLB is updated.

Make sure .RC file including elevated_controller.tlb is rebuilt every time .TLB is updated.

Also cleaned up an unnecessary use of Cygwin while generating elevated_controller.idl.

BUG=178633
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185132

[alexeypa (please no reviews), 2013-02-27 03:23:07]

PTAL.

[Wez, 2013-02-27 07:01:40]

https://chromiumcodereview.appspot.com/12315122/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://chromiumcodereview.appspot.com/12315122/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:1164: 'msvs_cygwin_shell': 0,
nit: I don't think this is related to the CL as such, so just mention that
you've cleaned up an unnecessary use of Cygwin in the CL description.

https://chromiumcodereview.appspot.com/12315122/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:1173: # rebuilt as well. GYP alone is not smart enough to
figure out this
The rule expresses a dependency on the .templ, but you're saying it triggers a
rebuild every time that the .tlb file changes - how does it achieve that?  Are
they always modified at the same time, for example?  If so, is there a risk that
some future toolchain updates the .templ before the .tlb, so that we miss the
.tlb change?

https://chromiumcodereview.appspot.com/12315122/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:1195: 'echo 1 typelib
"remoting/host/elevated_controller.tlb" > <@(_outputs)',
This writes the same single line to the file every time it generates it, so
you're effectively just "touch"ing it, each time the .templ changes?

[alexeypa (please no reviews), 2013-02-27 16:48:15]

PTAL.

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp#newcode...
remoting/remoting.gyp:1164: 'msvs_cygwin_shell': 0,
On 2013/02/27 07:01:40, Wez wrote:
> nit: I don't think this is related to the CL as such, so just mention that
> you've cleaned up an unnecessary use of Cygwin in the CL description.

Done.

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp#newcode...
remoting/remoting.gyp:1173: # rebuilt as well. GYP alone is not smart enough to
figure out this
On 2013/02/27 07:01:40, Wez wrote:
> The rule expresses a dependency on the .templ, but you're saying it triggers a
> rebuild every time that the .tlb file changes - how does it achieve that?

The remoting_controller_idl builds .tlb out of .templ.

> Are
> they always modified at the same time, for example?  If so, is there a risk
that
> some future toolchain updates the .templ before the .tlb, so that we miss the
> .tlb change?

I updated the description to clarify what is going on there.

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp#newcode...
remoting/remoting.gyp:1195: 'echo 1 typelib
"remoting/host/elevated_controller.tlb" > <@(_outputs)',
On 2013/02/27 07:01:40, Wez wrote:
> This writes the same single line to the file every time it generates it, so
> you're effectively just "touch"ing it, each time the .templ changes?

Yes. The contents of the file is important though. Touching somehow implies that
only the file name and last modification time matters, not the contents.

[Wez, 2013-02-27 21:49:59]

lgtm

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp#newcode...
remoting/remoting.gyp:1195: 'echo 1 typelib
"remoting/host/elevated_controller.tlb" > <@(_outputs)',
On 2013/02/27 16:48:15, alexeypa wrote:
> On 2013/02/27 07:01:40, Wez wrote:
> > This writes the same single line to the file every time it generates it, so
> > you're effectively just "touch"ing it, each time the .templ changes?
> 
> Yes. The contents of the file is important though. Touching somehow implies
that
> only the file name and last modification time matters, not the contents.

It's important to the build step, yes, but that's no different from an #include
- if #include deps were broken you'd just touch the .cc files that included
stuff to make them re-compile, not re-write them in their entirety.

[alexeypa (please no reviews), 2013-02-27 22:06:59]

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/12315122/diff/1/remoting/remoting.gyp#newcode...
remoting/remoting.gyp:1195: 'echo 1 typelib
"remoting/host/elevated_controller.tlb" > <@(_outputs)',
On 2013/02/27 21:50:00, Wez wrote:
> It's important to the build step, yes, but that's no different from an
#include
> - if #include deps were broken you'd just touch the .cc files that included
> stuff to make them re-compile, not re-write them in their entirety.

Touching a source file is a bad idea because the source files are supposed to be
read-only. The file in question is generated, so it is OK to touch it. The
problem is that the file is not guaranteed to exists so we have to generate it
anyway. :-)

[commit-bot: I haz the power, 2013-02-27 23:01:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12315122/3002

[commit-bot: I haz the power, 2013-02-28 03:39:54]

Change committed as 185132