Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: base/prefs/pref_registry.cc

Issue 12315116: Add ability to change default pref values, and use in BrowserInstantController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Add a bit of documentation. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/prefs/pref_registry.cc
diff --git a/base/prefs/pref_registry.cc b/base/prefs/pref_registry.cc
index c6fad4eb33baef6979a01beb177f8f4831b84e76..9ca1102e8f3a9ab0c92ff0ee05eee3c228953cc8 100644
--- a/base/prefs/pref_registry.cc
+++ b/base/prefs/pref_registry.cc
@@ -28,6 +28,21 @@ PrefRegistry::const_iterator PrefRegistry::end() const {
return defaults_->end();
}
+void PrefRegistry::SetDefaultPrefValue(const char* pref_name,
+ base::Value* value) {
+ DCHECK(value);
+ if (DCHECK_IS_ON()) {
+ const base::Value* current_value = NULL;
+ DCHECK(defaults_->GetValue(pref_name, &current_value))
+ << "Setting default for unregistered pref: " << pref_name;
+ DCHECK(value->IsType(current_value->GetType()))
+ << "Wrong type for new default: " << pref_name;
+ }
+
+ defaults_->RemoveDefaultValue(pref_name);
+ defaults_->SetDefaultValue(pref_name, value);
+}
+
void PrefRegistry::SetRegistrationCallback(
const RegistrationCallback& callback) {
registration_callback_ = callback;
« no previous file with comments | « base/prefs/pref_registry.h ('k') | base/prefs/pref_service.h » ('j') | base/prefs/pref_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698