Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: runtime/vm/dart_entry.h

Issue 12315087: Hook up simulator (if needed) when calling Dart code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.h
===================================================================
--- runtime/vm/dart_entry.h (revision 18982)
+++ runtime/vm/dart_entry.h (working copy)
@@ -105,40 +105,34 @@
const Array& arguments,
const Context& context);
- // Invokes the specified instance function on the receiver.
+ // Invoke the specified instance function or static function.
srdjan 2013/02/25 18:18:19 We try to use the third person in comments, i.e.,
regis 2013/02/25 19:24:06 Done.
+ // The first argument of an instance function is the receiver.
// On success, returns a RawInstance. On failure, a RawError.
// This is used when there are no named arguments in the call.
- static RawObject* InvokeDynamic(const Function& function,
- const Array& arguments);
+ static RawObject* InvokeFunction(const Function& function,
+ const Array& arguments);
- // Invokes the specified instance function on the receiver.
+ // Invoke the specified instance or static function.
// On success, returns a RawInstance. On failure, a RawError.
- static RawObject* InvokeDynamic(const Function& function,
- const Array& arguments,
- const Array& arguments_descriptor);
+ static RawObject* InvokeFunction(const Function& function,
+ const Array& arguments,
+ const Array& arguments_descriptor);
- // Invoke the specified static function.
+ // Invoke the specified instance, static, or closure function.
// On success, returns a RawInstance. On failure, a RawError.
- // This is used when there are no named arguments in the call.
- static RawObject* InvokeStatic(const Function& function,
- const Array& arguments);
+ static RawObject* InvokeFunction(const Function& function,
+ const Array& arguments,
+ const Array& arguments_descriptor,
+ const Context& context);
- // Invoke the specified static function.
+ // Invoke the closure object given as the first argument.
// On success, returns a RawInstance. On failure, a RawError.
- static RawObject* InvokeStatic(const Function& function,
- const Array& arguments,
- const Array& arguments_descriptor);
-
- // Invoke the specified closure object.
- // On success, returns a RawInstance. On failure, a RawError.
// This is used when there are no named arguments in the call.
- static RawObject* InvokeClosure(const Instance& closure,
- const Array& arguments);
+ static RawObject* InvokeClosure(const Array& arguments);
- // Invoke the specified closure object.
+ // Invoke the closure object given as the first argument.
// On success, returns a RawInstance. On failure, a RawError.
- static RawObject* InvokeClosure(const Instance& closure,
- const Array& arguments,
+ static RawObject* InvokeClosure(const Array& arguments,
const Array& arguments_descriptor);
// Invoke the noSuchMethod instance function on the receiver.
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698