Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 12315083: Merge 142534 (Closed)

7 years, 10 months ago by Peter Beverloo
7 years, 10 months ago
Peter Beverloo
Base URL:


Merge 142534 > [Text Autosizing] Collect narrow descendants and process them separately. Refactoring for > a change to follow. > > > Preparational change to combine narrow descendants of the same autosizing cluster into > groups by the width difference between the descendant and the block containing all text of > the parent autosizing cluster. The groups will be autosized with the same multiplier. > > For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have > a large margin individually applied (via a CSS selector), causing them all to individually > appear narrower than their enclosing blockContainingAllText. Rather than making each of > these paragraphs into a separate cluster, we eventually want to be able to merge them back > together into one (or a few) descendant clusters. > > Patch by Anton Vayvod <>; on 2013-02-11 > Reviewed by Julien Chaffraix. > > No behavioral changes thus no new tests or test changes. > > * rendering/TextAutosizer.cpp: > (TextAutosizingClusterInfo): Vector of narrow descendants. > (WebCore::TextAutosizer::processCluster): Process narrow descendants separately. > (WebCore::TextAutosizer::processContainer): > > Remember narrow descendants of the parent cluster for later processing. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M Source/WebCore/rendering/TextAutosizer.cpp View 5 chunks +18 lines, -2 lines 0 comments Download


Total messages: 2 (0 generated)
Peter Beverloo
7 years, 10 months ago (2013-02-25 16:44:36 UTC) #1
Peter Beverloo
7 years, 10 months ago (2013-02-25 16:44:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143928.

Powered by Google App Engine
This is Rietveld 408576698