Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12315071: Revert 184352 (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, Raghu Simha, jam, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, rpetterson, ahutter, yoshiki+watch_chromium.org, rdsmith+dwatch_chromium.org, dcheng, sreeram, chrome-speed-team+watch_google.com, stuartmorgan+watch_chromium.org, dmazzoni+watch_chromium.org, Raman Kakilate, kinuko+watch, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, benquan, rouslan+spellwatch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, kkania, dbeam+watch-autofill_chromium.org, dominich, darin-cc_chromium.org, tzik+watch_chromium.org, dennis_jeffrey, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), David Black, jennb, dyu1, browser-components-watch_chromium.org, melevin, jianli, gideonwald, groby+spellwatch_chromium.org, samarth+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, haitaol1, ctguil+watch_chromium.org, Jered, zork+watch_chromium.org, Ilya Sherman, achuith+watch_chromium.org, akalin, hashimoto+watch_chromium.org, tfarina, Dmitry Titov, sail+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, anantha, robertshield, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 184352 > Add utf_string_conversions to base namespace. > > This adds "using"s for all functions so those can be fixed in a separate pass. > > This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. > > BUG= > > Review URL: https://codereview.chromium.org/12314090 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -534 lines) Patch
M apps/app_host/update.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/utf_string_conversions.h View 2 chunks +0 lines, -21 lines 0 comments Download
M base/utf_string_conversions.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M base/utf_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/breakpad_win.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M chrome/app/client_util.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/about_flags_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/crash_upload_list_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_port_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_notification_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_publisher_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/in_memory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/query_parser_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/ie_importer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/importer_unittest_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/media_gallery/media_galleries_preferences_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_jpeg_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_data.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/database.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/policy/browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_path_parser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/speech/tts_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_device_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/tab_node_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 9 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
MM chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_stack_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/value_store/leveldb_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/logins_table_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/logging_chrome.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_reactivation_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/chrome_frame_ready_mode.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 5 chunks +13 lines, -15 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/auto_launch_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_finder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/indexeddb_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/page_cycler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/test/perf/startup_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/tab_switching_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/perf/url_fetch_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/file_upload_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/keycode_text_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/keycode_text_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/webdriver/webdriver_key_converter_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/webdriver/webdriver_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/aff_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/tools/ipclist/ipcfuzz.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years, 10 months ago (2013-02-24 21:13:50 UTC) #1
brettw
7 years, 10 months ago (2013-02-24 21:14:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r184355.

Powered by Google App Engine
This is Rietveld 408576698