Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 12315056: Merge 142913 (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142913 > [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try > https://bugs.webkit.org/show_bug.cgi?id=109671 > > Reviewed by James Robinson. > > My patch 142571 broke a bunch of things in handleGestureEvent that > assumed the event came in scaled, most notably tap highlight and > double-tap zoom. Switch those to PlatformGestureEvent. > > 142808 was an earlier version of this patch that was reverted > due to fling events asserting they can't be converted to > PlatformGestureEvent. This version moves fling earlier in the > function to avoid that. > > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::handleGestureEvent): > (WebKit::WebViewImpl::bestTapNode): > (WebKit::WebViewImpl::enableTapHighlight): > * src/WebViewImpl.h: > (WebViewImpl): > * tests/LinkHighlightTest.cpp: > (WebCore::TEST): > TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -48 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +329 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 10 chunks +47 lines, -39 lines 0 comments Download
M Source/WebKit/chromium/tests/LinkHighlightTest.cpp View 3 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:30:06 UTC) #1
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:31:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143775.

Powered by Google App Engine
This is Rietveld 408576698