Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1231503002: Move GN build files for cacheinvalidation into the main tree. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GN build files for cacheinvalidation into the main tree. Now that cacheinvalidation lives in the Chromium repo (after [1]), we can have these BUILD.gn files directly in third_party/cacheinvalidation. [1] - https://chromium.googlesource.com/chromium/src.git/+/4a996cdc7a36a71ac511c153375fc6170fea80e6 BUG=None TEST=gn gen out-gn/Debug still works R=zea@chromium.org,dpranke@chromium.org TBR=dpranke@chromium.org Committed: https://crrev.com/83904bbf870f05bc4f8640462d92a9919b0da84a Cr-Commit-Position: refs/heads/master@{#338156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -171 lines) Patch
D build/secondary/third_party/cacheinvalidation/BUILD.gn View 1 chunk +0 lines, -146 lines 0 comments Download
D build/secondary/third_party/cacheinvalidation/src/google/cacheinvalidation/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
A + third_party/cacheinvalidation/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/cacheinvalidation/src/google/cacheinvalidation/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
tfarina
5 years, 5 months ago (2015-07-07 20:39:22 UTC) #1
Nicolas Zea
lgtm
5 years, 5 months ago (2015-07-07 20:48:23 UTC) #2
Nicolas Zea
actually not lgtm, looks like that refers to //third_party still, could you update that?
5 years, 5 months ago (2015-07-07 20:49:06 UTC) #3
tfarina
On 2015/07/07 20:49:06, Nicolas Zea wrote: > actually not lgtm, looks like that refers to ...
5 years, 5 months ago (2015-07-07 20:53:27 UTC) #4
DaymAlaml
On 2015/07/07 20:53:27, tfarina wrote: > <font><font>في 2015/7/7 20:49:06 نيكولا زيا كتب:</font></font><font></font><font><font> > > في ...
5 years, 5 months ago (2015-07-07 20:59:18 UTC) #5
Nicolas Zea
Sorry, I forgot we wound up leaving cacheinvalidation in third_party (we had originally planned to ...
5 years, 5 months ago (2015-07-07 21:01:43 UTC) #6
tfarina
TBRing Dirk for this.
5 years, 5 months ago (2015-07-09 21:05:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231503002/1
5 years, 5 months ago (2015-07-09 21:08:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 21:45:06 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83904bbf870f05bc4f8640462d92a9919b0da84a Cr-Commit-Position: refs/heads/master@{#338156}
5 years, 5 months ago (2015-07-09 21:46:02 UTC) #11
Dirk Pranke
5 years, 5 months ago (2015-07-10 01:16:24 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698