Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 12315027: Fix Views Omnibox diagonal strike styling. (Closed)

Created:
7 years, 10 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su, sky
Visibility:
Public.

Description

Fix Views Omnibox diagonal strike styling. Clear the diagonal strike style (before potentially applying URL security styling). This was a simple regression from my http://crrev.com/180067 OmniboxViewViews previously cleared the diagonal strike style in line 919 of: https://chromiumcodereview.appspot.com/11535014/diff/57050/chrome/browser/ui/views/omnibox/omnibox_view_views.cc ApplyURLStyle(textfield_, 0, text.length(), base_color, false); My change still reset the overall textfield color, but not the diagonal strike style. BUG=177082 TEST=Get SSL error (https://cacert.org), new tab, switch back to SSL error tab; only scheme has a strike. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Peter, please take a look; thanks!
7 years, 10 months ago (2013-02-21 05:21:09 UTC) #1
Peter Kasting
LGTM
7 years, 10 months ago (2013-02-22 19:42:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12315027/1
7 years, 10 months ago (2013-02-23 15:50:20 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 18:09:29 UTC) #4
Message was sent while issue was closed.
Change committed as 184322

Powered by Google App Engine
This is Rietveld 408576698