Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5499)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.cc

Issue 12315019: Change ProxyRules to handle ProxyLists rather than just single ProxyServer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/proxy/proxy_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/proxy_config_service_impl.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl.cc b/chrome/browser/chromeos/proxy_config_service_impl.cc
index fc27fc1ff1cd809f5df98ab086ad8f581be43579..9a7c9f2702936b03ded92ddd3941ff00bd82bd84 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl.cc
@@ -202,29 +202,29 @@ bool ProxyConfigServiceImpl::ProxyConfig::FromNetProxyConfig(
}
return true;
case net::ProxyConfig::ProxyRules::TYPE_SINGLE_PROXY:
- if (!rules.single_proxy.is_valid())
+ if (rules.single_proxies.IsEmpty())
return false;
mode = MODE_SINGLE_PROXY;
- single_proxy.server = rules.single_proxy;
+ single_proxy.server = rules.single_proxies.Get();
bypass_rules = rules.bypass_rules;
return true;
case net::ProxyConfig::ProxyRules::TYPE_PROXY_PER_SCHEME:
// Make sure we have valid server for at least one of the protocols.
- if (!rules.proxy_for_http.is_valid() &&
- !rules.proxy_for_https.is_valid() &&
- !rules.proxy_for_ftp.is_valid() &&
- !rules.fallback_proxy.is_valid()) {
+ if (rules.proxies_for_http.IsEmpty() &&
+ rules.proxies_for_https.IsEmpty() &&
+ rules.proxies_for_ftp.IsEmpty() &&
+ rules.fallback_proxies.IsEmpty()) {
return false;
}
mode = MODE_PROXY_PER_SCHEME;
- if (rules.proxy_for_http.is_valid())
- http_proxy.server = rules.proxy_for_http;
- if (rules.proxy_for_https.is_valid())
- https_proxy.server = rules.proxy_for_https;
- if (rules.proxy_for_ftp.is_valid())
- ftp_proxy.server = rules.proxy_for_ftp;
- if (rules.fallback_proxy.is_valid())
- socks_proxy.server = rules.fallback_proxy;
+ if (!rules.proxies_for_http.IsEmpty())
+ http_proxy.server = rules.proxies_for_http.Get();
+ if (!rules.proxies_for_https.IsEmpty())
+ https_proxy.server = rules.proxies_for_https.Get();
+ if (!rules.proxies_for_ftp.IsEmpty())
+ ftp_proxy.server = rules.proxies_for_ftp.Get();
+ if (!rules.fallback_proxies.IsEmpty())
+ socks_proxy.server = rules.fallback_proxies.Get();
bypass_rules = rules.bypass_rules;
return true;
default:
@@ -306,28 +306,28 @@ bool ProxyConfigServiceImpl::ProxyConfig::DeserializeForDevice(
case net::ProxyConfig::ProxyRules::TYPE_NO_RULES:
return false;
case net::ProxyConfig::ProxyRules::TYPE_SINGLE_PROXY:
- if (!rules.single_proxy.is_valid())
+ if (rules.single_proxies.IsEmpty())
return false;
mode = MODE_SINGLE_PROXY;
- single_proxy.server = rules.single_proxy;
- break;
+ single_proxy.server = rules.single_proxies.Get();
+ return true;
case net::ProxyConfig::ProxyRules::TYPE_PROXY_PER_SCHEME:
// Make sure we have valid server for at least one of the protocols.
- if (!rules.proxy_for_http.is_valid() &&
- !rules.proxy_for_https.is_valid() &&
- !rules.proxy_for_ftp.is_valid() &&
- !rules.fallback_proxy.is_valid()) {
+ if (rules.proxies_for_http.IsEmpty() &&
+ rules.proxies_for_https.IsEmpty() &&
+ rules.proxies_for_ftp.IsEmpty() &&
+ rules.fallback_proxies.IsEmpty()) {
return false;
}
mode = MODE_PROXY_PER_SCHEME;
- if (rules.proxy_for_http.is_valid())
- http_proxy.server = rules.proxy_for_http;
- if (rules.proxy_for_https.is_valid())
- https_proxy.server = rules.proxy_for_https;
- if (rules.proxy_for_ftp.is_valid())
- ftp_proxy.server = rules.proxy_for_ftp;
- if (rules.fallback_proxy.is_valid())
- socks_proxy.server = rules.fallback_proxy;
+ if (!rules.proxies_for_http.IsEmpty())
+ http_proxy.server = rules.proxies_for_http.Get();
+ if (!rules.proxies_for_https.IsEmpty())
+ https_proxy.server = rules.proxies_for_https.Get();
+ if (!rules.proxies_for_ftp.IsEmpty())
+ ftp_proxy.server = rules.proxies_for_ftp.Get();
+ if (!rules.fallback_proxies.IsEmpty())
+ socks_proxy.server = rules.fallback_proxies.Get();
break;
}
} else {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/proxy/proxy_api_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698