Change ProxyRules to handle ProxyLists rather than just single ProxyServer instances.

net/proxy/proxy_config_service_common_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_common_unittest.h"
 
 #include <string>
 #include <vector>
 
 #include "net/proxy/proxy_config.h"
@@ skipping 63 matching lines @@
   ::testing::AssertionResult failure_details = ::testing::AssertionFailure();
   bool failed = false;
 
   if (rules.type != type) {
     failure_details << "Type mismatch. Expected: "
                     << type << " but was: " << rules.type;
     failed = true;
   }
 
   MatchesProxyServerHelper("Bad single_proxy", single_proxy,
-                           rules.single_proxy, &failure_details, &failed);
+                           rules.single_proxy.Get(), &failure_details, &failed);

[eroman, 2013/02/26 01:13:50]

It seems it would be appropriate to change the expectations here to a PAC style
string similar to what you did in the proxy_config_unitest.cc.  That may cause
lots of other updates.

At a minimum please assert that the list size is 1 here, since that is important
for correctness of the test verification (whereas changing to PAC strings is
about flexibility).

[marq_use_my_chromium_address, 2013/02/27 23:08:19]

Done.

   MatchesProxyServerHelper("Bad proxy_for_http", proxy_for_http,
-                           rules.proxy_for_http, &failure_details, &failed);
+                           rules.proxy_for_http.Get(), &failure_details,
+                           &failed);
   MatchesProxyServerHelper("Bad proxy_for_https", proxy_for_https,
-                           rules.proxy_for_https, &failure_details, &failed);
-  MatchesProxyServerHelper("Bad fallback_proxy", fallback_proxy,
-                           rules.fallback_proxy, &failure_details, &failed);
+                           rules.proxy_for_https.Get(), &failure_details,
+                           &failed);
 
   std::string actual_flattened_bypass = FlattenProxyBypass(rules.bypass_rules);
   if (std::string(flattened_bypass_rules) != actual_flattened_bypass) {
     failure_details
         << "Bad bypass rules. Expected: \"" << flattened_bypass_rules
         << "\" but got: \"" << actual_flattened_bypass << "\"";
     failed = true;
   }
 
   if (rules.reverse_bypass != reverse_bypass) {
@@ skipping 56 matching lines @@
     const char* proxy_http,
     const char* proxy_https,
     const char* proxy_ftp,
     const char* flattened_bypass_rules) {
   return ProxyRulesExpectation(ProxyConfig::ProxyRules::TYPE_PROXY_PER_SCHEME,
                                "", proxy_http, proxy_https, proxy_ftp, "",
                                flattened_bypass_rules, true);
 }
 
 }  // namespace net