Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 12315010: Merge 183348 (Closed)

Created:
7 years, 10 months ago by Alexei Svitkine (slow)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Merge 183348 > Fix spurious profile shortcuts created with a system-level install. > > This issue was caused by RenameChromeDesktopShortcutForProfile() > having logic to copy a system-level shortcut to make a user-level > shortcut in the case where a non-profile Chrome shortcut would > need to become a profile shortcut (i.e. the first user's profile > shortcut when creating a second user). > > This path was being triggered by the initial change of the profile > avatar when the profile was created. The fix is to not to try > updating profile shortcuts on name/avatar changes when we know the > profile never had a shortcut created (by virtue of the shortcut > name never getting stored). > > BUG=177047 > TEST=On a system-level install, create a new profile with the "create > shortcut" checkbox unchecked. A shortcut should not be created. Change > the profile's name or icon. The shortcut should still not appear. > Review URL: https://codereview.chromium.org/12300036 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexei Svitkine (slow)
7 years, 10 months ago (2013-02-20 20:12:24 UTC) #1
Alexei Svitkine (slow)
7 years, 10 months ago (2013-02-20 20:12:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r183600.

Powered by Google App Engine
This is Rietveld 408576698