Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 1231463002: Don't bother trying to reuse object pool entries for ICs, type test caches, or edge counters as the… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm64.cc
diff --git a/runtime/vm/flow_graph_compiler_arm64.cc b/runtime/vm/flow_graph_compiler_arm64.cc
index e2b8308c2fedb29bbbcd1ce5a9d6cee3f4e3b65f..f951807a88d3c8a0340603702d5871428833540b 100644
--- a/runtime/vm/flow_graph_compiler_arm64.cc
+++ b/runtime/vm/flow_graph_compiler_arm64.cc
@@ -224,7 +224,7 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateCallSubtypeTestStub(
const SubtypeTestCache& type_test_cache =
SubtypeTestCache::ZoneHandle(SubtypeTestCache::New());
StubCode* stub_code = isolate()->stub_code();
- __ LoadObject(R2, type_test_cache, PP);
+ __ LoadUniqueObject(R2, type_test_cache, PP);
if (test_kind == kTestTypeOneArg) {
ASSERT(type_arguments_reg == kNoRegister);
__ LoadObject(R1, Object::null_object(), PP);
@@ -617,7 +617,7 @@ void FlowGraphCompiler::GenerateInstanceOf(intptr_t token_pos,
// Push instantiator (R2) and its type arguments (R1).
__ Push(R2);
__ Push(R1);
- __ LoadObject(R0, test_cache, PP);
+ __ LoadUniqueObject(R0, test_cache, PP);
__ Push(R0);
GenerateRuntimeCall(token_pos, deopt_id, kInstanceofRuntimeEntry, 5, locs);
// Pop the parameters supplied to the runtime entry. The result of the
@@ -714,7 +714,7 @@ void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos,
__ Push(R2);
__ Push(R1);
__ PushObject(dst_name, PP); // Push the name of the destination.
- __ LoadObject(R0, test_cache, PP);
+ __ LoadUniqueObject(R0, test_cache, PP);
__ Push(R0);
GenerateRuntimeCall(token_pos, deopt_id, kTypeCheckRuntimeEntry, 6, locs);
// Pop the parameters supplied to the runtime entry. The result of the
@@ -1207,7 +1207,7 @@ void FlowGraphCompiler::EmitEdgeCounter() {
const Array& counter = Array::ZoneHandle(Array::New(1, Heap::kOld));
counter.SetAt(0, Smi::Handle(Smi::New(0)));
__ Comment("Edge counter");
- __ LoadObject(R0, counter, PP);
+ __ LoadUniqueObject(R0, counter, PP);
__ LoadFieldFromOffset(TMP, R0, Array::element_offset(0), PP);
__ add(TMP, TMP, Operand(Smi::RawValue(1)));
__ StoreFieldToOffset(TMP, R0, Array::element_offset(0), PP);
@@ -1230,7 +1230,7 @@ void FlowGraphCompiler::EmitOptimizedInstanceCall(
// Pass the function explicitly, it is used in IC stub.
__ LoadObject(R6, parsed_function().function(), PP);
- __ LoadObject(R5, ic_data, PP);
+ __ LoadUniqueObject(R5, ic_data, PP);
GenerateDartCall(deopt_id,
token_pos,
target_label,
@@ -1247,7 +1247,7 @@ void FlowGraphCompiler::EmitInstanceCall(ExternalLabel* target_label,
intptr_t token_pos,
LocationSummary* locs) {
ASSERT(Array::Handle(ic_data.arguments_descriptor()).Length() > 0);
- __ LoadObject(R5, ic_data, PP);
+ __ LoadUniqueObject(R5, ic_data, PP);
GenerateDartCall(deopt_id,
token_pos,
target_label,
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698