cc/trees/layer_tree_impl_unittest.cc - Issue 1231453002: Compute if a layer is clipped outside CalcDrawProps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_impl_unittest.cc

Issue 1231453002: Compute if a layer is clipped outside CalcDrawProps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DrawProperties is_clipped removed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_impl_unittest.cc

diff --git a/cc/trees/layer_tree_impl_unittest.cc b/cc/trees/layer_tree_impl_unittest.cc

index 81a566fe7f322d7bb6f57766f337e458b99dd22a..8947d959307d1d721022dde498697d636fb13683 100644

--- a/cc/trees/layer_tree_impl_unittest.cc

+++ b/cc/trees/layer_tree_impl_unittest.cc

@@ -972,6 +972,9 @@ TEST_F(LayerTreeImplTest, HitTestingRespectsScrollParents) {

// This should cause scroll child and its descendants to be affected by

// |child|'s clip.

scroll_child->SetScrollParent(child.get());

+ std::set<LayerImpl*>* scroll_children = new std::set<LayerImpl*>;

ajuma 2015/07/09 14:50:15 Nit: use a scoped_ptr here to make the ownership t

jaydasika 2015/07/09 15:11:49 Done.

+ scroll_children->insert(scroll_child.get());

+ child->SetScrollChildren(scroll_children);

SetLayerPropertiesForTesting(grand_child.get(), identity_matrix,

transform_origin, position, bounds, true,

« cc/trees/layer_tree_host_common.cc ('K') | « cc/trees/layer_tree_impl.cc ('k') | cc/trees/occlusion_tracker.cc » ('j') | cc/trees/property_tree_builder.cc » ('J')