Compute if a layer is clipped outside CalcDrawProps

cc/layers/layer.h

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_H_
 #define CC_LAYERS_LAYER_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 234 matching lines @@
   }
   bool draw_transform_is_animating() const {
     return draw_properties_.target_space_transform_is_animating;
   }
   bool screen_space_transform_is_animating() const {
     return draw_properties_.screen_space_transform_is_animating;
   }
   bool screen_space_opacity_is_animating() const {
     return draw_properties_.screen_space_opacity_is_animating;
   }
-  bool is_clipped() const { return draw_properties_.is_clipped; }
   gfx::Rect clip_rect() const { return draw_properties_.clip_rect; }
   gfx::Rect drawable_content_rect() const {
     return draw_properties_.drawable_content_rect;
   }
   gfx::Rect visible_layer_rect() const {
     return draw_properties_.visible_layer_rect;
   }
   Layer* render_target() {
     DCHECK(!draw_properties_.render_target ||
            draw_properties_.render_target->render_surface());
@@ skipping 227 matching lines @@
   void set_should_flatten_transform_from_property_tree(bool should_flatten) {
     if (should_flatten_transform_from_property_tree_ == should_flatten)
       return;
     should_flatten_transform_from_property_tree_ = should_flatten;
     SetNeedsPushProperties();
   }
   bool should_flatten_transform_from_property_tree() const {
     return should_flatten_transform_from_property_tree_;
   }
 
+  void set_is_clipped_from_property_tree(bool is_clipped) {
+    if (is_clipped_from_property_tree_ == is_clipped)
+      return;
+    is_clipped_from_property_tree_ = is_clipped;
+    SetNeedsPushProperties();
+  }
+  bool is_clipped_from_property_tree() const {

[Ian Vollick, 2015/07/09 14:26:27]

the "from_property_tree" suffix is only used to distinguish a method from its
non-property-tree analog. It's a reminder that we have to reconcile the two.
There is no such analog here, so this should just be called is_clipped.

[jaydasika, 2015/07/09 15:11:49]

Done.

+    return is_clipped_from_property_tree_;
+  }
+
   // TODO(vollick): These values are temporary and will be removed as soon as
   // render surface determinations are moved out of CDP. They only exist because
   // certain logic depends on whether or not a layer would render to a separate
   // surface, but CDP destroys surfaces and targets it doesn't need, so without
   // this boolean, this is impossible to determine after the fact without
   // wastefully recomputing it. This is public for the time being so that it can
   // be accessed from CDP.
   bool has_render_surface() const {
     return has_render_surface_;
   }
@@ skipping 178 matching lines @@
   int num_descendants_that_draw_content_;
   int transform_tree_index_;
   int opacity_tree_index_;
   int clip_tree_index_;
   int property_tree_sequence_number_;
   int num_layer_or_descendants_with_copy_request_;
   int num_layer_or_descendants_with_input_handler_;
   int num_children_with_scroll_parent_;
   gfx::Vector2dF offset_to_transform_parent_;
   bool should_flatten_transform_from_property_tree_ : 1;
+  bool is_clipped_from_property_tree_ : 1;
   bool should_scroll_on_main_thread_ : 1;
   bool have_wheel_event_handlers_ : 1;
   bool have_scroll_event_handlers_ : 1;
   bool user_scrollable_horizontal_ : 1;
   bool user_scrollable_vertical_ : 1;
   bool is_root_for_isolated_group_ : 1;
   bool is_container_for_fixed_position_layers_ : 1;
   bool is_drawable_ : 1;
   bool draws_content_ : 1;
   bool hide_layer_and_subtree_ : 1;
@@ skipping 53 matching lines @@
 
   std::vector<FrameTimingRequest> frame_timing_requests_;
   bool frame_timing_requests_dirty_;
 
   DISALLOW_COPY_AND_ASSIGN(Layer);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_H_