Compute if a layer is clipped outside CalcDrawProps

cc/trees/layer_tree_host_common.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_common.h"
 
 #include <algorithm>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/base/math_util.h"
@@ skipping 2043 matching lines @@
     } else {
       clip_rect_in_target_space = rect_in_target_space;
     }
   }
 
   // Tell the layer the rect that it's clipped by. In theory we could use a
   // tighter clip rect here (drawable_content_rect), but that actually does not
   // reduce how much would be drawn, and instead it would create unnecessary
   // changes to scissor state affecting GPU performance. Our clip information
   // is used in the recursion below, so we must set it beforehand.
-  layer_draw_properties.is_clipped = layer_or_ancestor_clips_descendants;
+  DCHECK_EQ(layer_or_ancestor_clips_descendants, layer->is_clipped());
   if (layer_or_ancestor_clips_descendants) {
     layer_draw_properties.clip_rect = clip_rect_in_target_space;
   } else {
     // Initialize the clip rect to a safe value that will not clip the
     // layer, just in case clipping is still accidentally used.
     layer_draw_properties.clip_rect = rect_in_target_space;
   }
 
   typename LayerType::LayerListType& descendants =
       (render_to_separate_surface ? layer->render_surface()->layer_list()
@@ skipping 325 matching lines @@
       transform->Preserves2dAxisAlignment() && *draw_transform_is_axis_aligned;
   if (IsRootLayer(layer) || (can_render_to_separate_surface &&
                              SubtreeShouldRenderToSeparateSurface(
                                  layer, preserves_2d_axis_alignment))) {
     // We reset the transform here so that any axis-changing transforms
     // will now be relative to this RenderSurface.
     transform->MakeIdentity();
     *draw_transform_is_axis_aligned = true;
     if (!layer->render_surface()) {
       layer->CreateRenderSurface();
+      layer->layer_tree_host()->property_trees()->needs_rebuild = true;

[ajuma, 2015/07/10 22:16:18]

How about doing this inside Layer::SetHasRenderSurface (whenever the new value
is different from the old one)?

[jaydasika, 2015/07/13 14:38:44]

Done.

     }
     layer->SetHasRenderSurface(true);
     return;
   }
   layer->SetHasRenderSurface(false);
-  if (layer->render_surface())
+  if (layer->render_surface()) {
     layer->ClearRenderSurface();
+    layer->layer_tree_host()->property_trees()->needs_rebuild = true;
+  }
 }
 
 void LayerTreeHostCommon::UpdateRenderSurfaces(
     Layer* layer,
     bool can_render_to_separate_surface,
     const gfx::Transform& parent_transform,
     bool draw_transform_is_axis_aligned) {
   gfx::Transform transform_for_children = layer->transform();
   transform_for_children *= parent_transform;
   draw_transform_is_axis_aligned &= layer->AnimationsPreserveAxisAlignment();
@@ skipping 67 matching lines @@
       << DrawTransformFromPropertyTrees(
              current_layer, property_trees->transform_tree).ToString();
 
   const bool draw_opacities_match =
       current_layer->draw_opacity() ==
       DrawOpacityFromPropertyTrees(current_layer, property_trees->opacity_tree);
   CHECK(draw_opacities_match)
       << "expected: " << current_layer->draw_opacity()
       << " actual: " << DrawOpacityFromPropertyTrees(
                             current_layer, property_trees->opacity_tree);
+
   const bool can_use_lcd_text_match =
       CanUseLcdTextFromPropertyTrees(
           current_layer, layers_always_allowed_lcd_text, can_use_lcd_text,
           property_trees) == current_layer->can_use_lcd_text();
   CHECK(can_use_lcd_text_match);
 }
 
 void VerifyPropertyTreeValues(
     LayerTreeHostCommon::CalcDrawPropsMainInputs* inputs) {
 }
@@ skipping 29 matching lines @@
 
   ProcessCalcDrawPropsInputs(*inputs, &globals, &data_for_recursion);
   UpdateMetaInformationSequenceNumber(inputs->root_layer);
   PreCalculateMetaInformationRecursiveData recursive_data;
   PreCalculateMetaInformationInternal(inputs->root_layer, &recursive_data);
 
   const bool should_measure_property_tree_performance =
       inputs->verify_property_trees &&
       (property_tree_option == BUILD_PROPERTY_TREES_IF_NEEDED);
 
-  if (should_measure_property_tree_performance) {
-    TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("cc.debug.cdp-perf"),
-                       "LayerTreeHostCommon::CalculateDrawProperties");
-  }
-
-  std::vector<AccumulatedSurfaceState<LayerType>> accumulated_surface_state;
-  CalculateDrawPropertiesInternal<LayerType>(
-      inputs->root_layer, globals, data_for_recursion,
-      inputs->render_surface_layer_list, &dummy_layer_list,
-      &accumulated_surface_state, inputs->current_render_surface_layer_list_id);
-
-  if (should_measure_property_tree_performance) {
-    TRACE_EVENT_END0(TRACE_DISABLED_BY_DEFAULT("cc.debug.cdp-perf"),
-                     "LayerTreeHostCommon::CalculateDrawProperties");
-  }
-
   if (inputs->verify_property_trees) {
     typename LayerType::LayerListType update_layer_list;
 
     // For testing purposes, sometimes property trees need to be built on the
     // compositor thread, so this can't just switch on Layer vs LayerImpl,
     // even though in practice only the main thread builds property trees.
     switch (property_tree_option) {
       case BUILD_PROPERTY_TREES_IF_NEEDED: {
         // The translation from layer to property trees is an intermediate
         // state. We will eventually get these data passed directly to the
@@ skipping 22 matching lines @@
       }
       case DONT_BUILD_PROPERTY_TREES: {
         TRACE_EVENT0(
             TRACE_DISABLED_BY_DEFAULT("cc.debug.cdp-perf"),
             "LayerTreeHostCommon::ComputeJustVisibleRectsWithPropertyTrees");
         ComputeVisibleRectsUsingPropertyTrees(
             inputs->root_layer, inputs->property_trees, &update_layer_list);
         break;
       }
     }
+  }
 
+  if (should_measure_property_tree_performance) {
+    TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("cc.debug.cdp-perf"),
+                       "LayerTreeHostCommon::CalculateDrawProperties");
+  }
+
+  std::vector<AccumulatedSurfaceState<LayerType>> accumulated_surface_state;
+  CalculateDrawPropertiesInternal<LayerType>(
+      inputs->root_layer, globals, data_for_recursion,
+      inputs->render_surface_layer_list, &dummy_layer_list,
+      &accumulated_surface_state, inputs->current_render_surface_layer_list_id);
+
+  if (should_measure_property_tree_performance) {
+    TRACE_EVENT_END0(TRACE_DISABLED_BY_DEFAULT("cc.debug.cdp-perf"),
+                     "LayerTreeHostCommon::CalculateDrawProperties");
+  }
+
+  if (inputs->verify_property_trees)
     VerifyPropertyTreeValues(inputs);
-  }
 
   // The dummy layer list should not have been used.
   DCHECK_EQ(0u, dummy_layer_list.size());
   // A root layer render_surface should always exist after
   // CalculateDrawProperties.
   DCHECK(inputs->root_layer->render_surface());
 }
 
 void LayerTreeHostCommon::CalculateDrawProperties(
     CalcDrawPropsMainInputs* inputs) {
@@ skipping 15 matching lines @@
 
 PropertyTrees* GetPropertyTrees(Layer* layer) {
   return layer->layer_tree_host()->property_trees();
 }
 
 PropertyTrees* GetPropertyTrees(LayerImpl* layer) {
   return layer->layer_tree_impl()->property_trees();
 }
 
 }  // namespace cc