chrome/common/chrome_notification_types.h - Issue 12314164: Modified Omnibox extension api to use JSON Schema Compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_notification_types.h

Issue 12314164: Modified Omnibox extension api to use JSON Schema Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replaced include with forward declaration Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_notification_types.h

diff --git a/chrome/common/chrome_notification_types.h b/chrome/common/chrome_notification_types.h

index a89ce0f75e965771023b2f32292682a67c2b8944..b0eb519ecbdaa67ee272a94895825fe12dd76915 100644

--- a/chrome/common/chrome_notification_types.h

+++ b/chrome/common/chrome_notification_types.h

@@ -638,8 +638,8 @@ enum NotificationType {

NOTIFICATION_EXTENSION_DOWNLOADS_EVENT,

// Sent when an omnibox extension has sent back omnibox suggestions. The

- // source is the profile, and the details are an ExtensionOmniboxSuggestions

- // object.

+ // source is the profile, and the details are an

+ // extensions::api::omnibox::SendSuggestions::Params object.

NOTIFICATION_EXTENSION_OMNIBOX_SUGGESTIONS_READY,

// Sent when the user accepts the input in an extension omnibox keyword

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/common/extensions/api/omnibox.json » ('j') | no next file with comments »