Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3472)

Unified Diff: chrome/common/extensions/api/omnibox.json

Issue 12314164: Modified Omnibox extension api to use JSON Schema Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kalman's requests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/omnibox.json
diff --git a/chrome/common/extensions/api/omnibox.json b/chrome/common/extensions/api/omnibox.json
index bcad7424c84d38afd754430ad0796054c6ac4202..6b47e6acd23d225c09f411965dbcc37657a2c4f7 100644
--- a/chrome/common/extensions/api/omnibox.json
+++ b/chrome/common/extensions/api/omnibox.json
@@ -14,12 +14,43 @@
"content": {
"type": "string",
"minLength": 1,
- "description": "The text that is put into the URL bar, and that is sent to the extension when the user chooses this entry."
+ "description": "The text that is put into the URL bar, and that is sent to the extension when the user chooses this entry. This field must be blank for $ref:setDefaultSuggestion."
},
"description": {
"type": "string",
"minLength": 1,
"description": "The text that is displayed in the URL dropdown. Can contain XML-style markup for styling. The supported tags are 'url' (for a literal URL), 'match' (for highlighting text that matched what the user's query), and 'dim' (for dim helper text). The styles can be nested, eg. <dim><match>dimmed match</match></dim>."
+ },
+ "descriptionStyles": {
+ "nodoc": true,
+ "optional": true,
+ "type": "array",
+ "description": "The style ranges for the description, as provided by the extension.",
+ "items": {
+ "type": "object",
+ "name": "matchClassification",
+ "description": "Placeholder description.",
+ "properties": {
+ "offset": { "type": "integer" },
+ "type": { "description": "The style type", "type": "string", "enum": ["url", "match", "dim"]},
+ "length": { "type": "integer", "optional": true }
+ }
+ }
+ },
+ "descriptionStylesRaw": {
+ "nodoc": true,
+ "optional": true,
+ "type": "array",
+ "description": "The style ranges for the description, as provided by ToValue().",
+ "items": {
+ "type": "object",
+ "name": "matchClassification",
+ "description": "Placeholder description.",
+ "properties": {
+ "offset": { "type": "integer" },
+ "type": { "type": "integer" }
+ }
+ }
}
}
}
@@ -35,10 +66,9 @@
{
"name": "suggestResults",
"type": "array",
- "description": "Array of suggest results",
+ "description": "An array of suggest results",
"items": {
- "type": "object",
- "additionalProperties": { "type": "any" }
+ "$ref": "SuggestResult"
}
}
]
@@ -49,16 +79,9 @@
"description": "Sets the description and styling for the default suggestion. The default suggestion is the text that is displayed in the first suggestion row underneath the URL bar.",
"parameters": [
{
- "type": "object",
"name": "suggestion",
- "description": "A partial SuggestResult object, without the 'content' parameter. See SuggestResult for a description of the parameters.",
- "properties": {
- "description": {
- "type": "string",
- "minLength": 1,
- "description": "The text to display in the default suggestion. The placeholder string '%s' can be included and will be replaced with the user's input."
- }
- }
+ "$ref": "SuggestResult",
+ "description": "A partial SuggestResult object, without the 'content' parameter. See SuggestResult for a description of the parameters."
}
]
}

Powered by Google App Engine
This is Rietveld 408576698