Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.h

Issue 12314164: Modified Omnibox extension api to use JSON Schema Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kalman's requests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.h
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.h b/chrome/browser/extensions/api/omnibox/omnibox_api.h
index 876a77ffe8f8ebc4f37cadab0bd008b353463d9c..bd2dbabd1ac68116a239d6f1f804d15b9700d4d3 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.h
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.h
@@ -15,6 +15,7 @@
#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_icon_manager.h"
+#include "chrome/common/extensions/api/omnibox.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -145,44 +146,6 @@ class OmniboxSetDefaultSuggestionFunction : public SyncExtensionFunction {
virtual bool RunImpl() OVERRIDE;
};
-struct ExtensionOmniboxSuggestion {
- ExtensionOmniboxSuggestion();
- ~ExtensionOmniboxSuggestion();
-
- // Populate a suggestion value from a DictionaryValue. If |require_content|
- // is false, then we won't fail if |content| is missing, to support
- // default suggestions.
- bool Populate(const base::DictionaryValue& value, bool require_content);
-
- // Converts a list of style ranges from the extension into the format expected
- // by the autocomplete system.
- bool ReadStylesFromValue(const base::ListValue& value);
-
- // Converts this structure to a DictionaryValue suitable for saving to disk.
- scoped_ptr<base::DictionaryValue> ToValue() const;
-
- // The text that gets put in the edit box.
- string16 content;
-
- // The text that is displayed in the drop down.
- string16 description;
-
- // Contains style ranges for the description.
- ACMatchClassifications description_styles;
-};
-
-struct ExtensionOmniboxSuggestions {
- ExtensionOmniboxSuggestions();
- ~ExtensionOmniboxSuggestions();
-
- int request_id;
- std::vector<ExtensionOmniboxSuggestion> suggestions;
-
- private:
- // This class is passed around by pointer.
- DISALLOW_COPY_AND_ASSIGN(ExtensionOmniboxSuggestions);
-};
-
// If the extension has set a custom default suggestion via
// omnibox.setDefaultSuggestion, apply that to |match|. Otherwise, do nothing.
void ApplyDefaultSuggestionForExtensionKeyword(
@@ -191,6 +154,11 @@ void ApplyDefaultSuggestionForExtensionKeyword(
const string16& remaining_input,
AutocompleteMatch* match);
+// This function converts style information populated by the JSON schema
+// // compiler into an ACMatchClassifications object.
+ACMatchClassifications StyleTypesToACMatchClassifications(
+ const api::omnibox::SuggestResult &suggestion);
+
} // namespace extensions
#endif // CHROME_BROWSER_EXTENSIONS_API_OMNIBOX_OMNIBOX_API_H_

Powered by Google App Engine
This is Rietveld 408576698