Modified Omnibox extension api to use JSON Schema Compiler

chrome/common/extensions/api/omnibox.json

Index: chrome/common/extensions/api/omnibox.json
diff --git a/chrome/common/extensions/api/omnibox.json b/chrome/common/extensions/api/omnibox.json
index bcad7424c84d38afd754430ad0796054c6ac4202..f3b40c9964f17a3cc97ad4034427bec7057bdc55 100644
--- a/chrome/common/extensions/api/omnibox.json
+++ b/chrome/common/extensions/api/omnibox.json
@@ -13,13 +13,45 @@
         "properties": {
           "content": {
             "type": "string",
+            "optional": true,

[not at google - send to devlin, 2013/03/22 17:33:30]

ugh, ok, I change my mind here sorry. this being optional is introducing some
complexity in the code that is a bit worrying (needing to check for null etc).

let's make this required again, but modify omnibox_custom_bindings.js to put it
in for setDefaultSuggestions: something like
https://codereview.chromium.org/12663022 should work (haven't tested it).

[Aaron Jacobs, 2013/03/22 19:54:15]

Done.

             "minLength": 1,
-            "description": "The text that is put into the URL bar, and that is sent to the extension when the user chooses this entry."
+            "description": "The text that is put into the URL bar, and that is sent to the extension when the user chooses this entry. This field must be ommitted for $ref:setDefaultSuggestion."
           },
           "description": {
             "type": "string",
             "minLength": 1,
             "description": "The text that is displayed in the URL dropdown. Can contain XML-style markup for styling. The supported tags are 'url' (for a literal URL), 'match' (for highlighting text that matched what the user's query), and 'dim' (for dim helper text). The styles can be nested, eg. <dim><match>dimmed match</match></dim>."
+          },
+          "descriptionStyles": {
+            "nodoc": true,
+            "optional": true,
+            "type": "array",
+            "description": "The style ranges for the description, as provided by the extension.",
+            "items": {
+              "type": "object",
+              "name": "matchClassification",
+              "description": "Placeholder description.",
+              "properties": {
+                "offset": { "type": "integer" },
+                "type": { "description": "The style type", "type": "string", "enum": ["url", "match", "dim"]},
+                "length": { "type": "integer", "optional": true }
+              }
+            }
+          },
+          "descriptionStylesRaw": {
+            "nodoc": true,
+            "optional": true,
+            "type": "array",
+            "description": "The style ranges for the description, as provided by ToValue().",
+            "items": {
+              "type": "object",
+              "name": "matchClassification",
+              "description": "Placeholder description.",
+              "properties": {
+                "offset": { "type": "integer" },
+                "type": { "type": "integer" }
+              }
+            }
           }
         }
       }
@@ -35,10 +67,9 @@
           {
             "name": "suggestResults",
             "type": "array",
-            "description": "Array of suggest results",
+            "description": "An array of suggest results",
             "items": {
-              "type": "object",
-              "additionalProperties": { "type": "any" }
+              "$ref": "SuggestResult"
             }
           }
         ]
@@ -49,16 +80,9 @@
         "description": "Sets the description and styling for the default suggestion. The default suggestion is the text that is displayed in the first suggestion row underneath the URL bar.",
         "parameters": [
           {
-            "type": "object",
             "name": "suggestion",
-            "description": "A partial SuggestResult object, without the 'content' parameter. See SuggestResult for a description of the parameters.",
-            "properties": {
-              "description": {
-                "type": "string",
-                "minLength": 1,
-                "description": "The text to display in the default suggestion. The placeholder string '%s' can be included and will be replaced with the user's input."
-              }
-            }
+            "$ref": "SuggestResult",
+            "description": "A partial SuggestResult object, without the 'content' parameter. See SuggestResult for a description of the parameters."
           }
         ]
       }